修复 notify 的bug #2405
Merged
修复 notify 的bug #2405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
LeoQuote
commented
Nov 23, 2023
LeoQuote
commented
- notify_for_execute 之前没有正确设置 event type, 导致逻辑错误
- 有些推送的 send 方法会需要 audit 对象, 所以在初始化对象时尝试获取一下 audit 对象
- 把根据 workflow 取 audit 对象的方法挪到 model 层
* notify_for_execute 之前没有正确设置 event type, 导致逻辑错误 * 有些推送的 send 方法会需要 audit 对象, 所以在初始化对象时尝试获取一下 audit 对象 * 把根据 workflow 取 audit 对象的方法挪到 model 层
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2405 +/- ##
==========================================
+ Coverage 76.32% 76.34% +0.02%
==========================================
Files 115 115
Lines 15837 15852 +15
==========================================
+ Hits 12087 12103 +16
+ Misses 3750 3749 -1 ☔ View full report in Codecov by Sentry. |
finovy
pushed a commit
to finovy/Archery
that referenced
this pull request
Dec 1, 2023
* 修复 notify 的bug * notify_for_execute 之前没有正确设置 event type, 导致逻辑错误 * 有些推送的 send 方法会需要 audit 对象, 所以在初始化对象时尝试获取一下 audit 对象 * 把根据 workflow 取 audit 对象的方法挪到 model 层 * 增加一行覆盖 * f * f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.