Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复审批流创建时的若干bug #2400

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Conversation

LeoQuote
Copy link
Collaborator

fix #2395

  1. 修复工单自动驳回时的工单状态未修改的bug
  2. 将 is_auto_review 改为 AuditV2 的方法, 防止审批流还未创建时调用出错

2. 将 is_auto_review 改为 AuditV2 的方法, 防止审批流还未创建时调用出错
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86f1bf6) 76.21% compared to head (729bdcc) 76.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2400      +/-   ##
==========================================
- Coverage   76.21%   76.20%   -0.01%     
==========================================
  Files         113      113              
  Lines       15799    15782      -17     
==========================================
- Hits        12041    12027      -14     
+ Misses       3758     3755       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LeoQuote LeoQuote merged commit 594b146 into hhyo:master Nov 21, 2023
10 checks passed
@LeoQuote LeoQuote deleted the fix_auto_review branch November 21, 2023 06:41
finovy pushed a commit to finovy/Archery that referenced this pull request Dec 1, 2023
1. 修复工单自动驳回时的工单状态未修改的bug
2. 将 is_auto_review 改为 AuditV2 的方法, 防止审批流还未创建时调用出错
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant