Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "新增sql执行行数限制" #2388

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Revert "新增sql执行行数限制" #2388

merged 1 commit into from
Nov 16, 2023

Conversation

LeoQuote
Copy link
Collaborator

@LeoQuote LeoQuote commented Nov 16, 2023

Reverts #2366

经核对, 此配置参照的是 goinception 提供的影响行数, 而此数据不可靠, 因为实现方式不可靠.

另外此配置也存在和之前行为不兼容的情况, 所以暂时 revert .

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff69c39) 76.21% compared to head (eaa6a8b) 76.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2388   +/-   ##
=======================================
  Coverage   76.21%   76.21%           
=======================================
  Files         113      113           
  Lines       15802    15799    -3     
=======================================
- Hits        12043    12041    -2     
+ Misses       3759     3758    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LeoQuote LeoQuote merged commit 5597911 into master Nov 16, 2023
11 checks passed
@LeoQuote LeoQuote deleted the revert-2366-master branch November 16, 2023 04:12
finovy pushed a commit to finovy/Archery that referenced this pull request Dec 1, 2023
Revert "新增sql执行行数限制 (hhyo#2366)"

This reverts commit d32d7bc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant