Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 慢日志统计页面无法展现SQL历史趋势图 #2331

Closed
wants to merge 1 commit into from
Closed

Fix 慢日志统计页面无法展现SQL历史趋势图 #2331

wants to merge 1 commit into from

Conversation

Grain-Yu
Copy link
Contributor

@Grain-Yu Grain-Yu commented Oct 13, 2023 •
edited
Loading

fix #2330

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (815cbd5) 75.50% compared to head (fef07ae) 75.50%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2331   +/-   ##
=======================================
  Coverage   75.50%   75.50%           
=======================================
  Files         107      107           
  Lines       15460    15460           
=======================================
  Hits        11673    11673           
  Misses       3787     3787

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Grain-Yu Grain-Yu changed the title Fix 慢日志统计页面无法展现SQL历史趋势图 #2330 Fix 慢日志统计页面无法展现SQL历史趋势图 Oct 13, 2023
LeoQuote
LeoQuote requested changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@LeoQuote LeoQuote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

固定 mysqlclient 不是很好, 请考虑下别的方案, 如果有 api 变化可以改内部的应用代码.

@hhyo
Copy link
Owner

hhyo commented Oct 24, 2023

Archery/sql/engines/mysql.py

Line 98 in fa2bb13

def escape_string(self, value: str) -> str:

使用这个方法处理

@Grain-Yu Grain-Yu closed this by deleting the head repository Oct 27, 2023
@Grain-Yu Grain-Yu mentioned this pull request Oct 30, 2023
Closed
@Grain-Yu Grain-Yu mentioned this pull request Nov 14, 2023
Merged
hhyo pushed a commit that referenced this pull request Nov 14, 2023
@Grain-Yu
修复无法展现SQL历史趋势图 (#2380)
ff69c39 
fix #2330
原PR: #2331
finovy pushed a commit to finovy/Archery that referenced this pull request Dec 1, 2023
@Grain-Yu @finovy
修复无法展现SQL历史趋势图 (hhyo#2380)
5504b69 
fix hhyo#2330
原PR: hhyo#2331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoQuote LeoQuote LeoQuote requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

慢日志统计页面无法展现SQL历史趋势图
3 participants
@Grain-Yu @hhyo @LeoQuote