Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escape on js variables #2318

Merged
merged 1 commit into from
Oct 9, 2023
Merged

escape on js variables #2318

merged 1 commit into from
Oct 9, 2023

Conversation

LeoQuote
Copy link
Collaborator

@LeoQuote LeoQuote commented Oct 9, 2023

之前的写法会因为错误的数据导致 js 运行不正常, 加上一些 escape, 以及独立到新的 script 区块, 防止整个页面不可用

@request-info
Copy link

request-info bot commented Oct 9, 2023

你好!感谢你反馈的问题/bug,但是你的描述好像是空的,我们需要你完整的信息,这样才能帮你解决问题 如果不知道怎么写,在新建issue的时候有若干个模板可供选择,祝好!

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (929ef03) 75.50% compared to head (22206c4) 75.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2318   +/-   ##
=======================================
  Coverage   75.50%   75.50%           
=======================================
  Files         107      107           
  Lines       15460    15460           
=======================================
  Hits        11673    11673           
  Misses       3787     3787           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LeoQuote LeoQuote merged commit faf8f98 into hhyo:master Oct 9, 2023
10 checks passed
Grain-Yu added a commit to Grain-Yu/archery-doris-1.10.0 that referenced this pull request Oct 10, 2023
@LeoQuote LeoQuote deleted the fix_unsafe_url branch October 24, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant