Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2252 #2266

Merged
merged 17 commits into from
Aug 28, 2023
Merged

fix #2252 #2266

merged 17 commits into from
Aug 28, 2023

Conversation

tonyhu214
Copy link
Contributor

@tonyhu214 tonyhu214 commented Aug 24, 2023

fix #2252 使用conn.current_schema=db_name 替换ALTER SESSION SET CURRENT_SCHEMA = :db_name 。
fix #2262 由于sql检测中可能存在影响行数位none的情况,针对性修复

@tonyhu214 tonyhu214 closed this Aug 24, 2023
@tonyhu214 tonyhu214 reopened this Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 40.00% and project coverage change: -0.02% ⚠️

Comparison is base (9d01416) 75.51% compared to head (181276e) 75.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2266      +/-   ##
==========================================
- Coverage   75.51%   75.50%   -0.02%     
==========================================
  Files         107      107              
  Lines       15460    15460              
==========================================
- Hits        11675    11673       -2     
- Misses       3785     3787       +2     
Files Changed Coverage Δ
sql/utils/sql_utils.py 90.85% <ø> (-0.06%) ⬇️
sql/engines/oracle.py 50.22% <40.00%> (-0.23%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tonyhu214 tonyhu214 closed this Aug 24, 2023
@tonyhu214 tonyhu214 reopened this Aug 24, 2023
@tonyhu214 tonyhu214 closed this Aug 24, 2023
@tonyhu214 tonyhu214 reopened this Aug 24, 2023
@tonyhu214 tonyhu214 closed this Aug 24, 2023
@tonyhu214 tonyhu214 reopened this Aug 24, 2023
@LeoQuote
Copy link
Collaborator

lint 修一下谢谢,只需要 black . —exclude venv 就可以了

另外不需要这样反复close open,只需要往你的分支里推送新代码,pr会自动更新的

@tonyhu214
Copy link
Contributor Author

@LeoQuote sry,昨天晚上加班,脑子有点迷糊

Copy link
Collaborator

@LeoQuote LeoQuote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这样改一下安全一些

sql/engines/oracle.py Outdated Show resolved Hide resolved
sql/engines/oracle.py Outdated Show resolved Hide resolved
@tonyhu214
Copy link
Contributor Author

@LeoQuote 非常感谢你的建议,基于你的建议我觉得get方法应该加上缺失默认值,避免key缺失导致异常。例如get("rows“, None)

@LeoQuote
Copy link
Collaborator

好的,不过get方法如果不指定第二个参数,返回的值就会是None

@LeoQuote LeoQuote merged commit 61f493e into hhyo:master Aug 28, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants