Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

新增钉钉认证登录 Feature/dingding login #2171

Merged
merged 13 commits into from
May 29, 2023
Merged

新增钉钉认证登录 Feature/dingding login #2171

merged 13 commits into from
May 29, 2023

Conversation

quanbisen
Copy link
Collaborator

@quanbisen quanbisen commented May 24, 2023

新增支持Dingding认证登录功能,我已新建了一个django-auth-dingding的外部应用,Archery这个项目install了这个app集成,配置文件的APP_KEY和APP_SECRET可参考Dingding官方文档. 配置文件如下:

ENABLE_DINGDING=true
AUTH_DINGDING_AUTHENTICATION_CALLBACK_URL=http://{host}:{port}/dingding/callback/
AUTH_DINGDING_APP_KEY=xxxx
AUTH_DINGDING_APP_SECRET=xxxx

@quanbisen quanbisen changed the title Feature/dingding login 新增钉钉认证登录 Feature/dingding login May 24, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage: 27.58% and project coverage change: -0.20 ⚠️

Comparison is base (73cd611) 75.44% compared to head (6b459ee) 75.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2171      +/-   ##
==========================================
- Coverage   75.44%   75.24%   -0.20%     
==========================================
  Files         103      105       +2     
  Lines       15133    15182      +49     
==========================================
+ Hits        11417    11424       +7     
- Misses       3716     3758      +42     
Impacted Files Coverage Δ
archery/urls.py 100.00% <ø> (ø)
common/authenticate/dingding_auth.py 0.00% <0.00%> (ø)
common/authenticate/oidc_auth.py 0.00% <ø> (ø)
common/middleware/check_login_middleware.py 100.00% <ø> (ø)
sql/views.py 64.00% <ø> (-0.12%) ⬇️
archery/settings.py 57.27% <36.36%> (-5.23%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@LeoQuote LeoQuote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一些修改和文件move 做得不错👍

archery/settings.py Outdated Show resolved Hide resolved
archery/settings.py Outdated Show resolved Hide resolved
@LeoQuote LeoQuote merged commit f8f1a8e into hhyo:master May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants