Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

数据库管理和账号管理支持MongoDB #2108

Merged
merged 7 commits into from
Apr 5, 2023
Merged

数据库管理和账号管理支持MongoDB #2108

merged 7 commits into from
Apr 5, 2023

Conversation

quanbisen
Copy link
Collaborator

新增支持MongoDB类型数据库管理和账号管理,抽取了接口在EngineBase接口中定义,若有需要其它数据库类型的,也可以实现该接口支持。instance_account表新增了字段db_name用作MongoDB存储用户的数据库。

@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Patch coverage: 44.80% and project coverage change: -0.09 ⚠️

Comparison is base (f611f03) 75.51% compared to head (c1c4d3b) 75.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2108      +/-   ##
==========================================
- Coverage   75.51%   75.43%   -0.09%     
==========================================
  Files         102      103       +1     
  Lines       14910    15105     +195     
==========================================
+ Hits        11259    11394     +135     
- Misses       3651     3711      +60     
Impacted Files Coverage Δ
sql/instance_account.py 10.59% <1.96%> (+0.15%) ⬆️
sql/instance_database.py 18.27% <5.00%> (-0.83%) ⬇️
sql/utils/instance_management.py 33.33% <33.33%> (ø)
sql/engines/__init__.py 65.34% <50.00%> (-1.69%) ⬇️
sql/engines/mongo.py 61.46% <64.51%> (+0.24%) ⬆️
sql/engines/mysql.py 76.98% <69.23%> (-1.19%) ⬇️
sql/engines/tests.py 99.79% <100.00%> (+<0.01%) ⬆️
sql/models.py 96.57% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hhyo
Copy link
Owner

hhyo commented Apr 1, 2023

感谢贡献,可以先用black处理下lint检测

@quanbisen
Copy link
Collaborator Author

代码已用black格式化

@nick2wang
Copy link
Collaborator

新增了不少方法,也更新下单元测试吧,辛苦了👍

@quanbisen
Copy link
Collaborator Author

已更新

@hhyo hhyo merged commit efbaa81 into hhyo:master Apr 5, 2023
nick2wang pushed a commit to nick2wang/Archery that referenced this pull request Apr 7, 2023
* add mongo db type management support

* 更新功能清单支持MongoDB账号管理

* refomat code by black

* add unittest for MySQL&MongoDB management function

---------

Co-authored-by: 小圈圈 <rtttte@qq.com>
(cherry picked from commit efbaa81)
@hhyo hhyo mentioned this pull request Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants