Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

新增配置项, enable_backup_switch, 允许工单提交人选择不备份 #200

Merged
merged 2 commits into from
May 14, 2019

Conversation

LeoQuote
Copy link
Collaborator

如果不配置或配置关闭, 用户只能选择备份工单.

相关issue #198

如果不配置或配置关闭, 用户只能选择备份工单.
@LeoQuote LeoQuote requested a review from hhyo May 14, 2019 06:38
@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #200 into master will increase coverage by 0.08%.
The diff coverage is 88.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
+ Coverage   73.14%   73.23%   +0.08%     
==========================================
  Files          63       63              
  Lines        6979     7006      +27     
==========================================
+ Hits         5105     5131      +26     
- Misses       1874     1875       +1
Impacted Files Coverage Δ
sql/views.py 41.84% <0%> (-0.23%) ⬇️
common/tests.py 100% <100%> (ø) ⬆️
sql/sql_workflow.py 62.65% <100%> (+0.45%) ⬆️
sql/tests.py 100% <100%> (ø) ⬆️
common/config.py 78.75% <81.81%> (+1.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ad4663...1a88d69. Read the comment docs.

@LeoQuote
Copy link
Collaborator Author

LeoQuote commented May 14, 2019

错误文案特别拗口, 我写的是 不允许提交不备份工单 .

目前还没在config页面上增加这个配置项
中文显示预计为: 开启不备份选项(建议不开启, 强制要求备份)

@hhyo hhyo merged commit e4d3487 into master May 14, 2019
@hhyo hhyo deleted the feature/force-backup branch May 14, 2019 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants