Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

处理clickhouse特殊数据类型序列化问题 #1525

Merged
merged 2 commits into from
May 19, 2022

Conversation

nick2wang
Copy link
Collaborator

@nick2wang nick2wang commented May 17, 2022

fix #1522
数据类型为UUID、IPv4、IPv6的序列化时转为字符串类型

@LeoQuote
Copy link
Collaborator

LeoQuote commented May 17, 2022

这里好像是直接改序列化的函数的, 试试改这里: https://github.com/hhyo/Archery/blob/master/common/utils/extend_json_encoder.py

@nick2wang
Copy link
Collaborator Author

这里好像是直接改序列化的函数的, 试试改这里: https://github.com/hhyo/Archery/blob/master/common/utils/extend_json_encoder.py

engine里的query是返回一个resultset对象,在通用的query视图里才会做序列化,如果去改通用的query会影响其他engine的查询效率,毕竟这个修改不是通用的,所以就直接在engine里改了

@LeoQuote
Copy link
Collaborator

这个转换的效率应该是可以接受的,除非可能会造成一些不符合预期的…

@nick2wang
Copy link
Collaborator Author

这个转换的效率应该是可以接受的,除非可能会造成一些不符合预期的…

转换应该是安全的,已修改为extend_json_encoder中处理

Copy link
Collaborator

@LeoQuote LeoQuote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhyo hhyo merged commit 5a7d666 into hhyo:master May 19, 2022
@nick2wang nick2wang deleted the fix-clickhouse-bug branch May 23, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ 问题咨询 ]查询clickhouse的uuid字段时报错can not convert type
3 participants