Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复odps查询不可用问题, 实例测试无效问题, 添加odps测试用例 #1454

Merged
merged 2 commits into from
Apr 10, 2022
Merged

Conversation

cpzt
Copy link
Contributor

@cpzt cpzt commented Apr 8, 2022

修复问题:
1.查询不可用,异常报错
2.实例测试无效
问题详见 #1430

新增:
1.odps测试用例

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #1454 (f29f1f1) into master (d40f48b) will increase coverage by 0.10%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##           master    #1454      +/-   ##
==========================================
+ Coverage   74.90%   75.01%   +0.10%     
==========================================
  Files          82       83       +1     
  Lines       13239    13405     +166     
==========================================
+ Hits         9917    10056     +139     
- Misses       3322     3349      +27     
Impacted Files Coverage Δ
sql/engines/odps.py 73.52% <74.07%> (ø)
sql/engines/tests.py 99.85% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d40f48b...f29f1f1. Read the comment docs.

Copy link
Collaborator

@LeoQuote LeoQuote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

专业,LGTM

@hhyo hhyo merged commit 9709c56 into hhyo:master Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants