Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

问题: mongodb表名带多个.的情况下, 无法正确截取methodStr. 原因是 默认截取第二个 "." 到"(" 之间的字符串作为method #1381

Merged
merged 5 commits into from
Feb 15, 2022

Conversation

CrusM
Copy link
Contributor

@CrusM CrusM commented Feb 14, 2022

问题: mongodb表名带多个.的情况下, 无法正确截取methodStr.
原因: 默认截取第二个 "." 到"(" 之间的字符串作为method
修改: 修改为截取最后一个"."到"(" 之间的字符串作为method

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #1381 (5cdbc7c) into master (360d052) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1381      +/-   ##
==========================================
- Coverage   75.39%   75.39%   -0.01%     
==========================================
  Files          81       81              
  Lines       12616    12615       -1     
==========================================
- Hits         9512     9511       -1     
  Misses       3104     3104              
Impacted Files Coverage Δ
sql/engines/mongo.py 47.84% <100.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 360d052...5cdbc7c. Read the comment docs.

@hhyo
Copy link
Owner

hhyo commented Feb 15, 2022

#1366 是不是解决的一个问题

@CrusM
Copy link
Contributor Author

CrusM commented Feb 15, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants