Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain that nullable fields in shapes are also optional #395

Merged
merged 1 commit into from
Dec 4, 2016

Conversation

barillari
Copy link
Contributor

Warn shape users that the typechecker conflates optional and nullable.

Warn shape users that the typechecker conflates optional and nullable.
@daviddoran
Copy link
Contributor

You could mention that Shapes::idx can be used to access a possibly missing or null field safely?

@fredemmott
Copy link
Contributor

See also #374 #375

?? is usable instead of Shapes::idx() and largely preferred externally (as it's not hack-specific and is just as safe)

@fredemmott
Copy link
Contributor

Merging in as-is - agree with @daviddoran, but that can be a separate PR

@fredemmott fredemmott merged commit 01ea198 into hhvm:master Dec 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants