fix assignments as expressions

Author: jjergus

src/PageSections/FunctionishReturnValues.hack

@@ -46,11 +46,12 @@ final class FunctionishReturnValues extends PageSection {
 
     $types =
       Vec\filter($docs['types'], $type ==> $type !== '\-' && $type !== '-');
+    $typehint = $f->getReturnType();
     if ($types) {
       $ret .= '`'.Str\join($types, '|').'`';
-    } else if ($type = $f->getReturnType()) {
+    } else if ($typehint) {
       $ret .=
-        '`'._Private\stringify_typehint($f->getNamespaceName(), $type).'`';
+        '`'._Private\stringify_typehint($f->getNamespaceName(), $typehint).'`';
     }
     $text = $docs['text'];
     if ($text !== null) {

src/PageSections/InterfaceSynopsis.hack

@@ -147,7 +147,8 @@ final class InterfaceSynopsis extends PageSection {
     if ($p !== null) {
       $ret .= ' extends '._Private\stringify_typehint($ns, $p);
     }
-    if ($interfaces = $c->getInterfaceInfo()) {
+    $interfaces = $c->getInterfaceInfo();
+    if ($interfaces) {
       $ret .= $interfaces
         |> Vec\map($$, $i ==> _Private\stringify_typehint($ns, $i))
         |> Str\join($$, ', ')

src/PageSections/_Private/stringify_functionish_signature.hack

@@ -55,7 +55,8 @@ function stringify_functionish_signature(
   $ret .= stringify_generics($ns, $function->getGenericTypes());
   $ret .= stringify_parameters($ns, $format, $function, $docs);
 
-  if ($type = $function->getReturnType()) {
+  $type = $function->getReturnType();
+  if ($type) {
     $ret .= ': '.stringify_typehint($ns, $type);
   }
 

src/PageSections/_Private/stringify_parameter.hack

@@ -26,10 +26,11 @@ function stringify_parameter(
   }
 
   $types = $docs['types'] ?? vec[];
+  $typehint = $parameter->getTypehint();
   if ($types) {
     $s .= Str\join($types, '|').' ';
-  } else if ($th = $parameter->getTypehint()) {
-    $s .= stringify_typehint($ns, $th).' ';
+  } else if ($typehint) {
+    $s .= stringify_typehint($ns, $typehint).' ';
   }
 
   if ($parameter->isVariadic()) {