remove support for &$references

jjergus · jjergus · commit 7aec065b1a28 · 2019-10-29T13:59:29.000-07:00
&amp;$references were removed from the Hack language in HHVM 4.29
diff --git a/.travis.yml b/.travis.yml
@@ -2,7 +2,7 @@ sudo: required
 language: generic
 services: docker
 env:
-- HHVM_VERSION=4.21-latest
+- HHVM_VERSION=4.29-latest
 - HHVM_VERSION=latest
 - HHVM_VERSION=nightly
 install:
diff --git a/composer.json b/composer.json
@@ -3,11 +3,11 @@
   "bin": [ "bin/hh-apidoc", "bin/hh-apidoc.hack" ],
   "license": "MIT",
   "require": {
-    "hhvm": "^4.14",
+    "hhvm": "^4.29",
     "hhvm/hsl": "^4.0",
     "facebook/fbmarkdown": "^1.0",
     "facebook/hh-clilib": "^2.1.0",
-    "facebook/definition-finder": "^2.12.3",
+    "facebook/definition-finder": "^2.13.0",
     "hhvm/hhast": "^4.14"
   },
   "require-dev": {
diff --git a/src/PageSections/_Private/stringify_parameter.hack b/src/PageSections/_Private/stringify_parameter.hack
@@ -35,9 +35,6 @@ function stringify_parameter(
   if ($parameter->isVariadic()) {
     $s .= '...';
   }
-  if ($parameter->isPassedByReference()) {
-    $s .= '&';
-  }
   $s .= '$'.$parameter->getName();
 
   if ($parameter->isOptional()) {

Original file line number	Diff line number	Diff line change
`@@ -35,9 +35,6 @@ function stringify_parameter(`
`35`	`35`	`if ($parameter->isVariadic()) {`
`36`	`36`	`$s .= '...';`
`37`	`37`	`}`
`38`		`- if ($parameter->isPassedByReference()) {`
`39`		`- $s .= '&';`
`40`		`- }`
`41`	`38`	`$s .= '$'.$parameter->getName();`
`42`	`39`
`43`	`40`	`if ($parameter->isOptional()) {`