Skip to content

Performance changes #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,19 @@ android {
abiFilters "armeabi-v7a", "x86"
}
}
signingConfigs {
release {
storeFile file(MYAPP_RELEASE_STORE_FILE)
storePassword MYAPP_RELEASE_STORE_PASSWORD
keyAlias MYAPP_RELEASE_KEY_ALIAS
keyPassword MYAPP_RELEASE_KEY_PASSWORD
}
}
buildTypes {
release {
signingConfig signingConfigs.release
}
}
splits {
abi {
reset()
Expand Down
Binary file added android/app/my-release-key.keystore
Binary file not shown.
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
package com.performanceexample;

import android.graphics.Color;
import android.graphics.drawable.Animatable;
import android.support.v7.widget.RecyclerView;
import android.util.Log;
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;

import com.facebook.react.bridge.ReadableMap;
import com.facebook.drawee.backends.pipeline.Fresco;
import com.facebook.drawee.view.SimpleDraweeView;
import com.facebook.drawee.interfaces.DraweeController;
import com.facebook.imagepipeline.request.ImageRequest;
import com.facebook.imagepipeline.request.ImageRequestBuilder;
import com.facebook.imagepipeline.common.ResizeOptions;
import com.facebook.imagepipeline.request.ImageRequest.RequestLevel;

import java.util.List;

import static android.support.v7.widget.RecyclerView.*;

public class CustomAdapter extends RecyclerView.Adapter<MyViewHolder> {
String TAG = "react";
private List<ListViewCell> list;

public CustomAdapter(List<ListViewCell> list) {
this.list = list;
}


@Override
public MyViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
View itemView = LayoutInflater.from(parent.getContext())
.inflate(R.layout.image_list_row, parent, false);
return new MyViewHolder(itemView);
}

@Override
public void onViewDetachedFromWindow (MyViewHolder holder) {
if ( holder.gifView.getController() != null) {
Animatable animatable = holder.gifView.getController().getAnimatable();
if (animatable != null) {
Log.d("Test", "animatable has allready been set");
// animatable.start();
// // later
animatable.stop();
} else {
Log.d("Test", "animatable has not been set");
}
}
}

@Override
public void onBindViewHolder(MyViewHolder holder, int position) {
ListViewCell listViewCell = list.get(position);

DraweeController controller = Fresco.newDraweeControllerBuilder()
.setUri(listViewCell.getUri())
.setAutoPlayAnimations(true)
.build();
holder.gifView.setController(controller);

//holder.gifView.setImageURI(listViewCell.getUri());
/*
ImageRequest imageRequest =
ImageRequestBuilder.newBuilderWithSource(listViewCell.getUri())
//.setResizeOptions(new ResizeOptions(350, 200))
.setLowestPermittedRequestLevel(RequestLevel.FULL_FETCH)
.build();
DraweeController draweeController = Fresco.newDraweeControllerBuilder()
.setImageRequest(imageRequest)
.setOldController(holder.gifView.getController())
.setAutoPlayAnimations(true)
.build();
holder.gifView.setController(draweeController);
*/
}

@Override
public int getItemCount() {
return list.size();
}


}
17 changes: 17 additions & 0 deletions android/app/src/main/java/com/performanceexample/ListViewCell.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
package com.performanceexample;

import android.net.Uri;

public class ListViewCell {
private Uri uri;

public ListViewCell(String uri) {
this.uri = Uri.parse(uri);
}


public Uri getUri() {
return uri;
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
package com.performanceexample;

import com.facebook.react.ReactPackage;
import com.facebook.react.bridge.JavaScriptModule;
import com.facebook.react.bridge.NativeModule;
import com.facebook.react.bridge.ReactApplicationContext;
import com.facebook.react.uimanager.ViewManager;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;


public class ListViewPackage implements ReactPackage {

@Override
public List<NativeModule> createNativeModules(ReactApplicationContext reactContext) {
return Collections.emptyList();
}

@Override
public List<Class<? extends JavaScriptModule>> createJSModules() {
return Collections.emptyList();
}

@Override
public List<ViewManager> createViewManagers(ReactApplicationContext reactContext) {
return Arrays.<ViewManager>asList(
new ReactListViewManager()
);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
import com.facebook.react.shell.MainReactPackage;
import com.facebook.soloader.SoLoader;

import com.performanceexample.ListViewPackage;

import java.util.Arrays;
import java.util.List;

Expand All @@ -24,8 +26,8 @@ public boolean getUseDeveloperSupport() {
@Override
protected List<ReactPackage> getPackages() {
return Arrays.<ReactPackage>asList(
new MainReactPackage()
);
new MainReactPackage(),
new ListViewPackage());
}
};

Expand Down
17 changes: 17 additions & 0 deletions android/app/src/main/java/com/performanceexample/MyViewHolder.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
package com.performanceexample;

import android.graphics.Color;
import android.support.v7.widget.RecyclerView;
import android.view.View;

import com.facebook.drawee.view.SimpleDraweeView;

public class MyViewHolder extends RecyclerView.ViewHolder {
public SimpleDraweeView gifView;

public MyViewHolder(View view) {
super(view);
gifView = (SimpleDraweeView) view.findViewById(R.id.my_image_view);

}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
package com.performanceexample;

import android.support.annotation.Nullable;
import android.support.v7.widget.DefaultItemAnimator;
import android.support.v7.widget.LinearLayoutManager;
import android.support.v7.widget.RecyclerView;
import android.util.Log;

import com.facebook.react.bridge.ReadableArray;
import com.facebook.react.bridge.ReadableMap;
import com.facebook.react.uimanager.SimpleViewManager;
import com.facebook.react.uimanager.ThemedReactContext;
import com.facebook.react.uimanager.ViewProps;
import com.facebook.react.uimanager.annotations.ReactProp;

import org.json.JSONArray;
import org.json.JSONException;
import org.json.JSONObject;

import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
import java.util.Map;

import static com.facebook.react.common.ReactConstants.TAG;

/**
* Created by root on 25/10/16.
*/

public class ReactListViewManager extends SimpleViewManager<RecyclerView> {
private List<ListViewCell> list = new ArrayList<>();
private RecyclerView recyclerView;
private CustomAdapter mAdapter;

@Override
public String getName() {
return "RCTListView";
}

@Override
protected RecyclerView createViewInstance(ThemedReactContext reactContext) {
mAdapter = new CustomAdapter(list);
return new RecyclerView(reactContext);
}

@ReactProp(name = "src")
public void setSrc(RecyclerView view,@Nullable ReadableMap src) {
view.setHasFixedSize(true);
RecyclerView.LayoutManager mLayoutManager = new LinearLayoutManager(view.getContext());
view.setLayoutManager(mLayoutManager);
view.setItemAnimator(new DefaultItemAnimator());
view.setAdapter(mAdapter);
prepareImageData(src);
}

private void prepareImageData(ReadableMap map){

ReadableArray obj = map.getArray("images");
for(int i = 0; i <obj.size() ; i++){
ReadableMap objMap = obj.getMap(i);
ListViewCell cell = new ListViewCell(objMap.getString("uri"));
list.add(cell);
}


mAdapter.notifyDataSetChanged();
}



}
15 changes: 15 additions & 0 deletions android/app/src/main/res/layout/image_list_row.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:fresco="http://schemas.android.com/apk/res-auto"
android:orientation="vertical"
android:layout_width="match_parent"
android:layout_height="match_parent">
<com.facebook.drawee.view.SimpleDraweeView
android:id="@+id/my_image_view"
android:layout_width="350dp"
android:layout_height="200dp"
fresco:placeholderImage="@mipmap/ic_launcher"
/>


</LinearLayout>
4 changes: 4 additions & 0 deletions android/gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,7 @@
# org.gradle.parallel=true

android.useDeprecatedNdk=true
MYAPP_RELEASE_STORE_FILE=my-release-key.keystore
MYAPP_RELEASE_KEY_ALIAS=my-key-alias
MYAPP_RELEASE_STORE_PASSWORD=password
MYAPP_RELEASE_KEY_PASSWORD=password
12 changes: 12 additions & 0 deletions js/AndroidImageList.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { PropTypes } from 'react';
import { requireNativeComponent, View } from 'react-native';

var iface = {
name: 'ImageView',
propTypes: {
src: PropTypes.object,
...View.propTypes // include the default view properties
},
}

module.exports = requireNativeComponent('RCTListView', iface)
9 changes: 2 additions & 7 deletions js/Background.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react'
import { Image, View } from 'react-native'
import bgImage from './assets/bg_transparent.png'
//import bgImage from './assets/bg_solid.png'

import bgImage from './assets/bg_solid.png'

import style from './Style'

Expand All @@ -14,16 +14,11 @@ export const BaseView = (props) => {
}

export const BgView = (props) => {
const propStyle = {
backgroundColor: 'transparent'
}

return (
<Image
source={bgImage}
style={style.pageBackground}>
<BaseView
style={propStyle}
{...props} />
</Image>
)
Expand Down
Loading