Skip to content

Add query params to log #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 5, 2021
Merged

Add query params to log #83

merged 4 commits into from
Nov 5, 2021

Conversation

@Webbrother
Copy link
Contributor

Implementation of query params logging. (see: #67)

@Webbrother Webbrother mentioned this pull request Mar 15, 2021
Closed
hg-pyun
hg-pyun reviewed Mar 15, 2021
View reviewed changes
Copy link
Owner

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thank you for your great PR. I don't have time right now, so I'll review it this weekend. There seems to be no problem.

@hg-pyun hg-pyun added the enhancement New feature or request label Mar 15, 2021
hg-pyun
hg-pyun approved these changes Mar 23, 2021
View reviewed changes
Copy link
Owner

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty Good. I will merge soon.

@hg-pyun hg-pyun changed the base branch from master to version/2.6.0 April 23, 2021 14:54
@hg-pyun
Copy link
Owner

hg-pyun commented Apr 23, 2021

I will merge to 2.6.0

@hg-pyun hg-pyun mentioned this pull request Nov 5, 2021
Closed
3 tasks
@hg-pyun hg-pyun merged commit dcbb168 into hg-pyun:version/2.6.0 Nov 5, 2021
hg-pyun added a commit that referenced this pull request Nov 7, 2021
@hg-pyun @Webbrother
Add query params to log (#83) (#100)
3156590 
* Add query params to log

* typo fix

* typo 2 fix

Co-authored-by: Haegul Pyun <phg2491@gmail.com>

Co-authored-by: WebBrother <komarov.vitaliy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hg-pyun hg-pyun hg-pyun approved these changes

+1 more reviewer

@sno2 sno2 sno2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Webbrother @hg-pyun @sno2