Repository navigation
fix(cli): preserve media after the last transcript word - #5325
Open
user-github-me wants to merge 1 commit into
Open
user-github-me wants to merge 1 commit into
user-github-me wants to merge 1 commit into
Conversation
Open
4 of 5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Preserve source media after the last transcript word when applying transcript cuts.
Why
On current main, removing a 0.5-second filler from a six-second source whose last word ends at four seconds produces only 3.5 seconds: the unrequested two-second outro is discarded. An explicit
--keep 4-6also fails with an empty cut list even though those seconds exist in the source.Related work
#1973 introduced the transcript-cut workflow, and #4179 addressed audio splices and codec priming. This corrects the duration supplied to the existing cut-list compiler. Current issues and all 137 open PR file inventories were checked; no competing transcript-cut implementation was found.
How
Probe the input before compiling the cuts and pass its duration through the compiler's existing option. A
--planwith--inputuses the same source duration as encoding, so its ranges match the output. Transcript-only planning remains available without media tools and uses the last word's end; help and operations documentation explain the distinction.Test plan