Skip to content

fix(core): seek current dotLottie players by frame - #5275

Merged
jrusso1020 merged 1 commit into
heygen-com:mainfrom
user-github-me:fix/dotlottie-set-frame
Oct 8, 2026
Merged

jrusso1020 merged 1 commit into
heygen-com:mainfrom
user-github-me:fix/dotlottie-set-frame

Conversation

@user-github-me

Copy link
Copy Markdown
Contributor

The runtime advertises support for @lottiefiles/dotlottie-web, but current players expose setFrame() rather than either legacy method the adapter calls. A paused player therefore remains on frame 0 through preview and render seeks.

Call the current frame API and derive its frame rate from totalFrames / duration, since current players do not expose frameRate. Wait for valid metadata, reuse the existing loop wrapping and final-frame hold, and retain the legacy player paths. The public dotLottie methods document setFrame.

Validation: nine regression cases fail on main; all 276 adapter tests pass. Chrome 152 with the published dotLottie 0.81.0 player reproduces the stuck frame before the fix. Afterward, ten loop, held, and mounted-scene samples match the player's native frame position and canvas pixels exactly, with no page errors. Core/runtime build and typechecks, repository lint, formatting, test reachability, hooks, and branch comment checks pass.

@jrusso1020 jrusso1020 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed against the published dotlottie-web types: current players expose setFrame, totalFrames and duration, and none of the methods the adapter calls today, so a paused player stays on frame 0 through seeks. Deriving the frame from totalFrames and duration and reusing the existing loop and hold logic is a clean fix, and the older player paths are untouched. The tests fail on main and pass here.

— Rames

@jrusso1020
jrusso1020 enabled auto-merge October 8, 2026 20:01
@jrusso1020
jrusso1020 added this pull request to the merge queue Oct 8, 2026
Merged via the queue into heygen-com:main with commit c94d992 Oct 8, 2026
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants