Repository navigation
fix(cli): honor authored durations when listing compositions - #5265
Merged
jrusso1020 merged 1 commit intoOct 8, 2026
Merged
jrusso1020 merged 1 commit into
jrusso1020 merged 1 commit into
Conversation
jrusso1020
approved these changes
Oct 8, 2026
jrusso1020
left a comment
Collaborator
There was a problem hiding this comment.
Thanks. hyperframes compositions ignored an inline root's declared duration and let child clips stretch an external composition past its declared trim, so the listing disagreed with what the runtime plays. Routing both paths through the shared duration reader and resolver fixes that and removes a duplicated parser. The invalid-value cases are well covered.
— Rames
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hyperframes compositionsignores an inline root'sdata-duration: a declared 8-second composition with a 2-second child is listed as 2 seconds. External compositions have the opposite trim problem: a declared 2.5-second composition with a 7-second child is listed as 7 seconds. Invalid external declarations can also produceInfinityor accept numeric prefixes.Use the existing shared duration reader and resolver for both listings. A valid authored duration wins; otherwise the command derives the duration from child ends and keeps its external script fallback.
Validation: seven regression cases fail on main; 88 CLI composition, metadata, and timeline tests passed. The built CLI lists all eight shipped example projects successfully. Engine/parser/CLI builds, CLI typecheck, repository lint, formatting, test reachability, and hooks passed.