Skip to content

fix(cli): honor authored durations when listing compositions - #5265

Merged
jrusso1020 merged 1 commit into
heygen-com:mainfrom
user-github-me:fix/compositions-authored-duration
Oct 8, 2026
Merged

jrusso1020 merged 1 commit into
heygen-com:mainfrom
user-github-me:fix/compositions-authored-duration

Conversation

@user-github-me

Copy link
Copy Markdown
Contributor

hyperframes compositions ignores an inline root's data-duration: a declared 8-second composition with a 2-second child is listed as 2 seconds. External compositions have the opposite trim problem: a declared 2.5-second composition with a 7-second child is listed as 7 seconds. Invalid external declarations can also produce Infinity or accept numeric prefixes.

Use the existing shared duration reader and resolver for both listings. A valid authored duration wins; otherwise the command derives the duration from child ends and keeps its external script fallback.

Validation: seven regression cases fail on main; 88 CLI composition, metadata, and timeline tests passed. The built CLI lists all eight shipped example projects successfully. Engine/parser/CLI builds, CLI typecheck, repository lint, formatting, test reachability, and hooks passed.

@jrusso1020 jrusso1020 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. hyperframes compositions ignored an inline root's declared duration and let child clips stretch an external composition past its declared trim, so the listing disagreed with what the runtime plays. Routing both paths through the shared duration reader and resolver fixes that and removes a duplicated parser. The invalid-value cases are well covered.

— Rames

@jrusso1020
jrusso1020 enabled auto-merge October 8, 2026 19:57
@jrusso1020
jrusso1020 added this pull request to the merge queue Oct 8, 2026
Merged via the queue into heygen-com:main with commit 1094b8e Oct 8, 2026
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants