fix(producer): reject regression audio stream mismatches

packages/producer/scripts/test-classification.mjs

@@ -12,6 +12,7 @@ const INTEGRATION_TEST_FILES = new Set([
   "tests/distributed/_smoke/webm-concat-copy.test.ts",
   "tests/playback-rate-av-parity/playback-rate-av-parity.test.ts",
   "src/regression-harness-psnr.test.ts",
+  "src/regression-harness-audio.test.ts",
   "src/services/bundleScriptPolicy.test.ts",
   "src/services/coreRuntimeBrowser.test.ts",
   "src/services/vfxDeterminism.test.ts",

packages/producer/src/regression-harness-audio.test.ts

@@ -0,0 +1,95 @@
+import { describe, expect, it } from "vitest";
+import { execFileSync } from "node:child_process";
+import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
+import { join } from "node:path";
+import { tmpdir } from "node:os";
+import { getFfmpegBinary } from "@hyperframes/engine";
+import { compileForRender } from "./services/htmlCompiler.js";
+import { runTestSuite } from "./regression-harness.js";
+
+function ffmpeg(args: string[]): void {
+  execFileSync(getFfmpegBinary(), ["-y", "-hide_banner", "-loglevel", "error", ...args], {
+    timeout: 30_000,
+  });
+}
+
+describe("regression audio stream presence", () => {
+  it.each([
+    { renderedAudio: false, snapshotAudio: true, passed: false },
+    { renderedAudio: true, snapshotAudio: false, passed: false },
+    { renderedAudio: false, snapshotAudio: false, passed: true },
+    { renderedAudio: true, snapshotAudio: true, passed: true },
+  ])(
+    "rendered audio $renderedAudio, snapshot audio $snapshotAudio: passes $passed",
+    async ({ renderedAudio, snapshotAudio, passed }) => {
+      const dir = mkdtempSync(join(tmpdir(), "hf-regression-audio-"));
+      try {
+        const srcDir = join(dir, "src");
+        const outputDir = join(dir, "output");
+        mkdirSync(srcDir);
+        mkdirSync(outputDir);
+        const html = `<!doctype html><html><head><style>html,body{margin:0;width:160px;height:120px;background:#000}#root{position:absolute;inset:0;background:#000}</style></head><body><div id="root" data-composition-id="audio-presence" data-no-timeline data-width="160" data-height="120" data-start="0" data-duration="1">${renderedAudio ? '<audio id="audio" class="clip" src="silence.wav" data-start="0" data-duration="1" data-track-index="0"></audio>' : ""}</div></body></html>`;
+        const inputPath = join(srcDir, "index.html");
+        writeFileSync(inputPath, html);
+        if (renderedAudio) {
+          ffmpeg([
+            "-f",
+            "lavfi",
+            "-i",
+            "anullsrc=r=16000:cl=mono",
+            "-t",
+            "1",
+            join(srcDir, "silence.wav"),
+          ]);
+        }
+        const compiled = await compileForRender(srcDir, inputPath, join(dir, "downloads"));
+        writeFileSync(join(outputDir, "compiled.html"), compiled.html);
+        ffmpeg([
+          "-f",
+          "lavfi",
+          "-i",
+          "color=c=black:s=160x120:r=10:d=1",
+          ...(snapshotAudio ? ["-f", "lavfi", "-i", "anullsrc=r=16000:cl=mono"] : []),
+          "-map",
+          "0:v:0",
+          ...(snapshotAudio ? ["-map", "1:a:0"] : []),
+          "-t",
+          "1",
+          "-c:v",
+          "libx264",
+          "-pix_fmt",
+          "yuv420p",
+          ...(snapshotAudio ? ["-c:a", "aac"] : []),
+          join(outputDir, "output.mp4"),
+        ]);
+
+        const result = await runTestSuite(
+          {
+            id: "audio-presence",
+            dir,
+            srcDir,
+            meta: {
+              name: "Audio presence",
+              description: "Audio streams must exist on both sides or neither",
+              tags: [],
+              minPsnr: 30,
+              maxFrameFailures: 0,
+              minAudioCorrelation: 0,
+              maxAudioLagWindows: 1,
+              renderConfig: { fps: { num: 10, den: 1 }, workers: 1, captureMode: "screenshot" },
+            },
+          },
+          { update: false, keepTemp: false, mode: "in-process" },
+        );
+
+        expect(result.compilation?.passed).toBe(true);
+        expect(result.visual?.passed).toBe(true);
+        expect(result.audio?.passed).toBe(passed);
+        expect(result.passed).toBe(passed);
+      } finally {
+        rmSync(dir, { recursive: true, force: true });
+      }
+    },
+    30_000,
+  );
+});

packages/producer/src/regression-harness.ts

@@ -973,7 +973,7 @@ export function createRegressionTempRoot(suiteId: string, parent: string = tmpdi
   return mkdtempSync(join(parent, `hyperframes-test-${suiteId}-`));
 }
 
-async function runTestSuite(
+export async function runTestSuite(
   suite: TestSuite,
   options: {
     update: boolean;
@@ -1372,7 +1372,16 @@ async function runTestSuite(
       const renderedAudio = extractMonoPcm16(renderedOutputPath);
       const snapshotAudio = extractMonoPcm16(snapshotVideoPath);
 
-      if (renderedAudio.length > 0 && snapshotAudio.length > 0) {
+      const renderedHasAudio = renderedAudio.length > 0;
+      const snapshotHasAudio = snapshotAudio.length > 0;
+      if (renderedHasAudio !== snapshotHasAudio) {
+        audioPassed = false;
+        audioCorrelation = -1;
+        logPretty(
+          `Audio stream mismatch: rendered=${renderedHasAudio ? "present" : "missing"}, snapshot=${snapshotHasAudio ? "present" : "missing"}`,
+          "✗",
+        );
+      } else if (renderedHasAudio && snapshotHasAudio) {
         const renderedEnvelope = buildRmsEnvelope(renderedAudio);
         const snapshotEnvelope = buildRmsEnvelope(snapshotAudio);
         const audio = compareAudioEnvelopes(

scripts/test-reachability.json

@@ -61,7 +61,7 @@
       ],
       "sources": {
         "packages/producer/scripts/run-test-lane.mjs": "638885e14480d03290803389325a655f3749442167d784e07bb3af3404598af7",
-        "packages/producer/scripts/test-classification.mjs": "cdfa4035d0e2c0b1fea4d4c5b4697e0287d48c4474ab105f5e3d1ce839cca500",
+        "packages/producer/scripts/test-classification.mjs": "4753e8d0dd1c2de80f8bf4e98cfaef495aa4c0d39a403b1a60d69190a00b0f02",
         ".github/workflows/ci.yml#job#producer-source-tests": "45da72aa6cf08cdfd5bcf5311e89f12af4842f9eebc6735df19da8c02f4d4864",
         "packages/producer/package.json#script#test:unit": "ae6beda8319d166774be958ea5593cd27dbf7f6c9bce1d787a3fe28dfc3477b1",
         "packages/producer/package.json#script#test:integration": "008589f37d026877595a13501cbb66abd5cbe50e21fdcac6904f45466c3f475d",