Repository navigation
fix(lint): detect optional managed media calls - #5210
Merged
jrusso1020 merged 1 commit intoOct 8, 2026
Merged
Conversation
jrusso1020
approved these changes
Oct 8, 2026
jrusso1020
left a comment
Collaborator
There was a problem hiding this comment.
Confirmed that video?.play() and video.play?.() slip past imperative_media_control on main, even though the plain call is an error. Widening the existing matchers and using the existing JS code mask is a small, consistent fix, and the quoted-example controls are a good addition. The new cases fail on main, and the full lint suite passes.
— Rames
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optional chaining currently bypasses
imperative_media_control:video?.play(),video.play?.(), and optional calls on direct DOM lookups pass lint even though HyperFrames must own managed-media playback. The same rule also reports ordinary calls printed inside strings, comments, templates, or regular expressions.Extend the existing play/pause matchers to optional property access and optional calls. Use the existing JavaScript code mask to check that bindings and controls begin in executable code, retaining real calls inside template interpolations. Existing finding messages, snippets for ordinary calls, and media IDs are preserved.
Validation:
No new dependency or runtime playback change.