Repository navigation
fix(cli): recognize ancestor gradient text masks - #5207
Merged
jrusso1020 merged 1 commit intoOct 8, 2026
Merged
Conversation
jrusso1020
approved these changes
Oct 8, 2026
jrusso1020
left a comment
Collaborator
There was a problem hiding this comment.
Thanks. This removes a real false positive: split-text gradient headings were reported as text_not_painted even though their glyphs paint. Matching each clip to its background layer, while keeping glyphs outside the mask reportable, keeps the check honest, and the Chromium screenshot tests back up the version gate. Two small follow-ups you could consider: on Chrome below 150 the check still flags plain inline children that are painted, and an ancestor url() background is still flagged even though the direct-text path accepts it.
— Rames
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a heading uses
background-clip: textand its words or lines are wrapped in child elements,checkreportstext_not_paintedeven though Chrome 150+ paints their glyphs. Recognize an ancestor's clipped gradient or solid background, match the painted background layer, and compare individual text fragments in layout coordinates because Chromium's mask ignores descendant transforms.Keep the finding for Chrome builds below 150 and unknown browsers, transparent or missing gradients, unmatched background layers, SVG text, and glyphs outside the mask. Ancestor images with unknown transparency remain conservative. Refs #5117 for the CLI audit follow-up; the Cloud Run browser pin remains a separate issue.
Validation:
text_not_paintedon main to a passing strict lint/check with three passing contrast samples; Chrome 148 still reports the genuinely missing child glyphs.