Skip to content

feat(skills): c2v mining pass — 7 new blueprints, 10 new rules, compacted recipe corpus#2680

Merged
WaterrrForever merged 3 commits into
mainfrom
miao/c2v-mining-blueprints
Jul 21, 2026
Merged

feat(skills): c2v mining pass — 7 new blueprints, 10 new rules, compacted recipe corpus#2680
WaterrrForever merged 3 commits into
mainfrom
miao/c2v-mining-blueprints

Conversation

@WaterrrForever

@WaterrrForever WaterrrForever commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

What

Blueprint/rule corpus refresh from the c2v mining pass over the golden-clip corpus. Four moves:

  1. 7 new blueprintsagent-progress-theater, camera-journey, fixed-anchor-cycle, panel-edit-live-sync, prompt-type-submit-generate, transcript-scroll-artifact-reveal, zoom-out-workspace-reveal. These name the AI-product demo grammar the corpus kept hitting and the existing catalog couldn't express (typed prompt → machine answers, agent working-state theater, transcript-scroll → artifact payoff, panel edit with live-synced target) plus two camera-narrative shapes (multi-leg motivated journeys, the single decelerating zoom-out nesting reveal). Each ships with roles served, scene-by-scene shot structure, motion vocabulary, and a full rule mapping.

  2. 10 new rules3d-camera-flight, anchored-layout-expand, chart-scrub-readout, chromatic-glitch, control-target-sync, cursor-drag, gradient-text-sweep, multi-cursor-choreography, particle-burst, theme-crossfade-morph: motion verbs the new blueprints cite that had no owning recipe.

  3. ~45 existing rules/blueprints compacted into tighter recipe form (net −3.4k lines), with role widenings where new goldens attested them (cursor-ui-demo → Hook/Benefits, dataviz-countup → Hook/Key_Feature/Social_Proof, titlecard-reveal → CTA/Product_Intro card chains, cta-morph-press → Hook, device-surface-showcase → Product_Intro, spatial-pan-stations → Product_Intro, constellation-hub → CTA). Both indexes updated.

  4. product-launch script bank re-synced 1:1 with the index — story-design.md's role→blueprint script bank gains the 25 missing entries (script-shape descriptor + example lines + pattern): 13 for the new blueprints, 12 for the role widenings. The bank intro now states the 1:1 sync contract so future blueprint role changes carry a bank entry with them.

Tests

  • bun run lint:skills — 31 skill files, no issues
  • bun run format:check — clean (3402 files)
  • skills manifest regenerated; git diff --exit-code skills-manifest.json clean after regen

@jrusso1020 jrusso1020 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COMMENT — content verified across all three review lenses

Home routed this to me for the content-level review; posting as COMMENT since Miao asked for review, not stamp. All three checks land clean.

1. New content is well-formed and indexed

7 new blueprints all ship at the right shape (intent / roles served / duration / shot structure / motion vocabulary / rule mapping — same pattern as cursor-ui-demo.md etc.), all present as files at skills/hyperframes-animation/blueprints/:

  • agent-progress-theater.md (16 KB)
  • camera-journey.md (13 KB)
  • fixed-anchor-cycle.md (9 KB)
  • panel-edit-live-sync.md (13 KB)
  • prompt-type-submit-generate.md (19 KB)
  • transcript-scroll-artifact-reveal.md (12 KB)
  • zoom-out-workspace-reveal.md (15 KB)

All 7 appear in blueprints-index.md.

10 new rules all present at skills/hyperframes-animation/rules/, all listed in rules-index.md, and each is referenced by at least one blueprint (so no dead-on-arrival rules):

Rule Referenced by
3d-camera-flight 2 files
anchored-layout-expand 7 files
chart-scrub-readout 2 files
chromatic-glitch 2 files
control-target-sync 2 files
cursor-drag 2 files
gradient-text-sweep 2 files
multi-cursor-choreography 2 files
particle-burst 4 files
theme-crossfade-morph 2 files

2. Compaction didn't drop still-referenced content

The −8205 / +4950 net −3.4k lines is compaction, not deletion:

  • 0 files removed — every one of the 45+ heavily-shrunk rules (some at 20-30% of prior size, e.g. avatar-cloud-network.md at 85+/311−, physics-press-reaction.md at 72+/321−) is still present as a file at the same path.
  • Rule-reference sweep across all blueprints — extracted every backtick-quoted rule slug in skills/hyperframes-animation/blueprints/*.md and compared against the actual rules/ file set. Every reference resolves to a live file at PR head. No orphaned rule refs.
  • Blueprint-reference sweep — same check for blueprint slugs. No orphaned blueprint refs.

The line reduction came from tightening prose inside each rule/blueprint, not by dropping named entries the corpus still cites.

3. Script bank is 1:1 with the role index — verified

Parsed skills/product-launch-video/references/story-design.md § "The script bank" (H3 role sections → **blueprint** sub-headings) and cross-referenced against the role declarations in the blueprint files themselves:

blueprint-file (role, blueprint) pairs: 52
script-bank    (role, blueprint) pairs: 52
in blueprints, MISSING from script bank: 0
in script bank, MISSING from blueprints: 0

Exact 1:1 match. The PR body's claim ("re-synced 1:1 with the expanded role index") holds precisely — including all 25 previously-missing entries the PR body called out.

Other verifications

  • motion-doctrine performing-status exemption — both mirrors (.claude/skills/motion-doctrine/SKILL.md + .agents/skills/motion-doctrine/SKILL.md) byte-identical (md5 e2fb2417…). Exemption text is well-motivated by the two new blueprints that need it (prompt-type-submit-generate and agent-progress-theater both perform diegetic working-state motion that would otherwise trip the idle-wobble ban).
  • CI at snapshot: 6 pass / 0 failed / rest pending. Deployment, Format, File size check, Semantic PR title all green.

Not a blocker but noting

Nothing found — content survives every audit dimension I could run against it.

Verdict

COMMENT — LGTM on content. Miao, if you want the stamp: routing goes through @jrusso1020's identity (my gh CLI). Say the word here or in DM and I'll flip to APPROVE. Otherwise this stays additive to @miga-heygen's parallel pass.

— Rames Jusso

@miga-heygen miga-heygen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SSOT Review: feat(skills): c2v mining pass — 7 new blueprints, 10 new rules, compacted recipe corpus

PR #2680 — 70 files, +4950/-8205


SSOT inventory

Concept Source(s) of truth
Blueprint catalog blueprints-index.md <blueprint> tags (22 entries)
Blueprint details blueprints/<id>.md (22 files)
Rule catalog rules-index.md <rule> tags (41 entries)
Rule details rules/<id>.md (41 files)
Role → blueprint menu blueprints-index.md "Role → blueprint menu" section
Script bank (VO shapes) product-launch-video/references/story-design.md "The script bank" section
Motion doctrine .claude/skills/motion-doctrine/SKILL.md + .agents/skills/motion-doctrine/SKILL.md (mirrors)
Skill hashes skills-manifest.json

What I checked

  1. Blueprint index count: Header says "The 22 blueprints" — enumerated all 22 <blueprint> tags. 15 original + 7 new = 22. PASS.

  2. New blueprint files exist and are indexed: All 7 new files (agent-progress-theater, camera-journey, fixed-anchor-cycle, panel-edit-live-sync, prompt-type-submit-generate, transcript-scroll-artifact-reveal, zoom-out-workspace-reveal) have matching <blueprint id="..."> entries in blueprints-index.md. Filename ↔ ID ↔ # title consistency verified for all 7. PASS.

  3. New rule files exist and are indexed: All 10 new files (3d-camera-flight, anchored-layout-expand, chart-scrub-readout, chromatic-glitch, control-target-sync, cursor-drag, gradient-text-sweep, multi-cursor-choreography, particle-burst, theme-crossfade-morph) have matching entries in rules-index.md under correct category sections. Filename ↔ tag name ↔ frontmatter name consistency verified for spot-checked files. PASS.

  4. Role → blueprint menu completeness: Every new blueprint's declared roles appear in the role menu, and every new role-menu entry points to a blueprint that exists. Verified all 7 new blueprints + all role widenings (cta-morph-press→Hook, constellation-hub→CTA, cursor-ui-demo→Hook/Benefits, device-surface-showcase→Product_Intro, dataviz-countup→Hook/Key_Feature/Social_Proof, titlecard-reveal→CTA/Product_Intro, spatial-pan-stations→Product_Intro). PASS.

  5. Script bank 1:1 sync with role index: story-design.md claims "Kept 1:1 with the role declarations in ../hyperframes-animation/blueprints-index.md." Enumerated all new role-menu entries across 8 roles and checked each has a corresponding script bank entry. 38 of 39 new/widened entries present. One gap — see Blocking Issues. PARTIAL.

  6. Cross-reference integrity (blueprint → rule): Spot-checked rule mappings in agent-progress-theater.md (25+ rule refs) and camera-journey.md (25+ rule refs). All cited rules resolve to existing or new-in-this-PR rule files. References to golden-shape provenance names (e.g. message-thread-payoff, scatter-drift-finisher) are clearly labeled as variant provenance, not rule names. PASS.

  7. Motion doctrine mirror sync: Compared the diff hunks for .agents/skills/motion-doctrine/SKILL.md and .claude/skills/motion-doctrine/SKILL.md — identical content (performing-status exemption paragraph). Both reference the same golden corpus examples (prompt-type-submit-generate, agent-progress-theater). PASS.

  8. skills-manifest.json: hyperframes-animation hash updated (7b3cd6bfb4adace4), file count 104 → 121 (+17 = 7 new blueprints + 10 new rules). product-launch-video hash updated (file count unchanged at 26 — only story-design.md modified). PASS.

  9. No deleted files: Confirmed zero deleted file mode entries in the diff. No orphaned index entries possible from deletions. PASS.

  10. Coverage footnote accuracy: "dataviz-countup now spans 5" — verified 5 roles in the tag (Hook, Problem, Product_Intro, Key_Feature, Social_Proof). "seven more ... mined from the golden-clip corpus" — counted 7 names. "4–11 options" per role — verified minimum is Problem with 4, maximum is Hook and Key_Feature with 11. PASS.

  11. Structural completeness of new files: Spot-checked agent-progress-theater.md (76 lines), camera-journey.md (61 lines), 3d-camera-flight.md (180 lines), chart-scrub-readout.md (151 lines). All have: intent + boundary note, roles served with provenance, duration with member ranges, shot structure with scenes, motion vocabulary, rule mapping, camera modifier, and doctrine/seek-safety notes where applicable. PASS.

  12. Rules-index contract section: New "The contract — every rule assumes this" block added at the top of rules-index.md. States shared invariants (paused timeline, seek-safety, deterministic, transform-only, no CSS transition, etc.) so individual rules can omit repetition. Consistent with the compaction story (net -3.2k lines). PASS.

Blocking SSOT issues

1. Missing script bank entry: constellation-hub scatter-drift under SOCIAL_PROOF

The role menu in blueprints-index.md adds a new Social_Proof entry:

+- `constellation-hub` — scatter-drift end card: ~20 app icons pop in frame-wide
  around a serif headline and drift outward under a static frame
  ("connects to thousands of apps").

The constellation-hub.md blueprint file adds the corresponding role variant:

+- Social_Proof (from `scatter-drift-finisher`): the ecosystem beat as a
  static END CARD — a two-line serif [headline] ...

But story-design.md's SOCIAL_PROOF section does not add a matching script bank entry. The only addition under SOCIAL_PROOF is dataviz-countup. The existing constellation-hub entry ("the hub at the center of your stack") covers the orbit-ecosystem variant, not the scatter-drift.

This violates the file's own sync claim: "Kept 1:1 with the role declarations in ../hyperframes-animation/blueprints-index.md."

Fix: Add a script bank entry under SOCIAL_PROOF, after the existing constellation-hub entry or after dataviz-countup:

**constellation-hub** — ecosystem by scatter and drift

- "[Product] connects to Slack, Notion, Figma, Linear, and thousands more."
- _Pattern:_ a serif headline holds center while ~20 app icons pop in scattered
  around it and drift slowly outward — the count and the drift say "everywhere,"
  no geometry needed.

Non-blocking observations

  1. Role menu range claim: The header says "Each role has 4–11 options" — this is accurate post-PR but was "2–4" before. The update is correct; just noting the jump.

  2. New rules-index contract is additive-only: The contract block is well-placed, but individual existing rules that previously stated these invariants in their own Critical Constraints sections may now have redundant text. The compaction pass likely handled this, but a quick grep for "paused timeline" or "seek-safe" duplication across existing rule files could confirm. Not blocking — the contract block itself explicitly says "A rule's own Critical Constraints section lists only what is SPECIFIC to that rule beyond this contract."

  3. constellation-hub duration string: The <blueprint> tag says duration="5–8s (scatter-drift end card ~2.5s)" — the 2.5s scatter-drift end card is well below the general 5–8s range, making the duration string a bit ambiguous (is the 5–8s inclusive of scatter-drift, or exclusive?). The blueprint detail file clarifies, so not blocking.

Verdict

Changes Requested — one blocking SSOT gap.

The scatter-drift constellation-hub variant is properly defined in the blueprint file, properly indexed in the role menu, but missing its 1:1 counterpart in the script bank. Everything else checks out: all 17 new files indexed, all cross-references resolve, motion-doctrine mirrors match, manifest hashes updated, structural completeness verified on spot-checks.

Fix the one missing script bank entry and this is clean.

--- Miga

WaterrrForever added a commit that referenced this pull request Jul 21, 2026
…ript bank

Review follow-up on #2680: the SOCIAL_PROOF constellation-hub entry
patterned only the orbit shape; the c2v pass added a scatter-drift
end-card variant with the opposite geometry (no hub, no ring). Adds an
example line and extends the pattern so a scatter-drift beat's VO isn't
steered toward the orbit shape.

@miga-heygen miga-heygen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review: feat(skills): c2v mining pass (R2)

The blocking gap is fixed. The constellation-hub SOCIAL_PROOF script bank entry now includes the scatter-drift end-card variant inline — "In the scatter-drift end-card variant there is no hub and no ring: a serif claim holds center while app icons pop in scattered and drift slowly outward — breadth said with count and spread, not geometry." Plus an additional VO line ("Connects to thousands of apps…"). Manifest hash updated.

Script bank is now 1:1 with the role index — 39 of 39 entries accounted for.

Approve. No remaining blocking issues.

--- Miga

@jrusso1020 jrusso1020 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping the content lens: delta since my prior COMMENT is zero new commits, and the scatter-drift addition on the previous head was a 3-line variant note on the constellation-hub SOCIAL_PROOF entry — non-load-bearing. Blueprints ↔ script-bank 1:1 confirmed on the prior pass. Miga's re-review + independent approve above corroborates.

WaterrrForever added a commit that referenced this pull request Jul 21, 2026
…ript bank

Review follow-up on #2680: the SOCIAL_PROOF constellation-hub entry
patterned only the orbit shape; the c2v pass added a scatter-drift
end-card variant with the opposite geometry (no hub, no ring). Adds an
example line and extends the pattern so a scatter-drift beat's VO isn't
steered toward the orbit shape.
@WaterrrForever
WaterrrForever force-pushed the miao/c2v-mining-blueprints branch from 8ccd485 to a72b94e Compare July 21, 2026 09:10
Compacts ~45 existing animation rules/blueprints into tighter recipe form
(net -3.4k lines) and adds 17 mined from the c2v corpus:

- 7 blueprints: agent-progress-theater, camera-journey, fixed-anchor-cycle,
  panel-edit-live-sync, prompt-type-submit-generate,
  transcript-scroll-artifact-reveal, zoom-out-workspace-reveal
- 10 rules: 3d-camera-flight, anchored-layout-expand, chart-scrub-readout,
  chromatic-glitch, control-target-sync, cursor-drag, gradient-text-sweep,
  multi-cursor-choreography, particle-burst, theme-crossfade-morph






Both indexes updated.
The role->blueprint script bank in product-launch-video/story-design.md is
kept 1:1 with blueprints-index role declarations, which the c2v mining pass
expanded. Adds the 25 missing entries (script-shape descriptor + example
lines + pattern): 13 for the 7 new blueprints, 12 for role widenings on 7
existing ones (cursor-ui-demo, dataviz-countup, titlecard-reveal, et al.),
and states the 1:1 sync contract in the bank's intro.
…ript bank

Review follow-up on #2680: the SOCIAL_PROOF constellation-hub entry
patterned only the orbit shape; the c2v pass added a scatter-drift
end-card variant with the opposite geometry (no hub, no ring). Adds an
example line and extends the pattern so a scatter-drift beat's VO isn't
steered toward the orbit shape.
@WaterrrForever
WaterrrForever force-pushed the miao/c2v-mining-blueprints branch from a72b94e to 318472f Compare July 21, 2026 09:11

@jrusso1020 jrusso1020 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-stamping after rebase — verified all 22 touched files are byte-identical (same GitHub blob SHAs) between the previously-approved head 617fd5b and current head 318472f. Pure rebase onto latest main; the approve was auto-dismissed by hyperframes' stale-review-on-push protection, not by any content change. Content lens verdict from the prior review still stands.

@WaterrrForever
WaterrrForever merged commit 8532564 into main Jul 21, 2026
39 checks passed
@WaterrrForever
WaterrrForever deleted the miao/c2v-mining-blueprints branch July 21, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants