fix: make UserConfig interface instead of type#989
Merged
mrlubos merged 1 commit intohey-api:mainfrom Aug 28, 2024
jacobinu:fix/config-type-error
Merged
fix: make UserConfig interface instead of type#989mrlubos merged 1 commit intohey-api:mainfrom jacobinu:fix/config-type-error
mrlubos merged 1 commit intohey-api:mainfrom
jacobinu:fix/config-type-error
Conversation
|
|
🦋 Changeset detectedLatest commit: bc78a42 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #989 +/- ##
=======================================
Coverage 76.15% 76.15%
=======================================
Files 89 89
Lines 10953 10953
Branches 1111 1111
=======================================
Hits 8341 8341
Misses 2605 2605
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
commit: |
mrlubos
approved these changes
Aug 28, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #661
Similar problems with exporting a type alias:
Seems like this is intentional, explanation can be found here: privatenumber/cleye#11 (comment)
Should we want
createClientanddefineConfigto take an array we can just make the parameterconfigtypeUserConfig | ReadonlyArray<UserConfig>.