fix(sdk): preserve required body properties in flat params signatures#3456
fix(sdk): preserve required body properties in flat params signatures#3456vcombey wants to merge 1 commit intohey-api:mainfrom
Conversation
|
Leaping into action... |
|
|
|
@vincentcombey-design is attempting to deploy a commit to the Hey API Team on Vercel. A member of the Team first needs to authorize it. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3456 +/- ##
==========================================
+ Coverage 40.11% 40.37% +0.25%
==========================================
Files 478 478
Lines 17488 17489 +1
Branches 5294 5301 +7
==========================================
+ Hits 7016 7061 +45
+ Misses 8425 8392 -33
+ Partials 2047 2036 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b02916d to
56d6517
Compare
56d6517 to
f482160
Compare

Summary
Fix flattened body requiredness in SDK signatures when using
paramsStructure: 'flat'.Closes #3455.
Problem
For object request bodies, flattened properties were marked required by checking
property.required, which is not valid at property level in OpenAPI schema objects.OpenAPI requiredness for object properties is defined by the parent schema
requiredarray. A property schema does not have its ownrequiredflag.