Skip to content

refactor(transformers): transform date only if date is format date-time and not date#3216

Open
qlaffont wants to merge 2 commits intohey-api:mainfrom
qlaffont:main
Open

refactor(transformers): transform date only if date is format date-time and not date#3216
qlaffont wants to merge 2 commits intohey-api:mainfrom
qlaffont:main

Conversation

@qlaffont
Copy link

The current implementation is not true and can produce some errors. This MR fix it !

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2026

⚠️ No Changeset found

Latest commit: ff113e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug 🔥 Broken or incorrect behavior. labels Jan 20, 2026
@vercel
Copy link

vercel bot commented Jan 20, 2026

@qlaffont is attempting to deploy a commit to the Hey API Team on Vercel.

A member of the Team first needs to authorize it.

@qlaffont
Copy link
Author

qlaffont commented Jan 20, 2026

@mrlubos glad to have your advice/review on it !

@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.12%. Comparing base (8129464) to head (ff113e1).

Files with missing lines Patch % Lines
...s/src/plugins/@hey-api/transformers/expressions.ts 0.00% 1 Missing ⚠️
...src/plugins/@hey-api/typescript/v1/toAst/string.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3216   +/-   ##
=======================================
  Coverage   35.12%   35.12%           
=======================================
  Files         400      400           
  Lines       22299    22299           
  Branches     1444     1444           
=======================================
  Hits         7833     7833           
  Misses      14462    14462           
  Partials        4        4           
Flag Coverage Δ
unittests 35.12% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 21, 2026

Open in StackBlitz

@hey-api/codegen-core

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/codegen-core@3216

@hey-api/nuxt

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@3216

@hey-api/openapi-ts

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@3216

@hey-api/types

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/types@3216

@hey-api/vite-plugin

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@3216

commit: b95b6e1

@qlaffont
Copy link
Author

qlaffont commented Feb 6, 2026

@mrlubos any update on this one ? Need some edits ? Actually, we have some error in a production project due to this…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🔥 Broken or incorrect behavior. size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant