Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle discriminators in experimental parser #1267

Merged
merged 1 commit into from
Nov 10, 2024

fix: handle discriminators in experimental parser

ff3aa4a
Select commit
Loading
Failed to load commit list.
Merged

fix: handle discriminators in experimental parser #1267

fix: handle discriminators in experimental parser
ff3aa4a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 10, 2024 in 0s

67.56% (-0.08%) compared to 04c88dd

View this Pull Request on Codecov

67.56% (-0.08%) compared to 04c88dd

Details

Codecov Report

Attention: Patch coverage is 52.88136% with 139 lines in your changes missing coverage. Please review.

Project coverage is 67.56%. Comparing base (04c88dd) to head (ff3aa4a).

Files with missing lines Patch % Lines
...ages/openapi-ts/src/openApi/3.0.x/parser/schema.ts 9.48% 105 Missing ⚠️
...ages/openapi-ts/src/openApi/3.1.x/parser/schema.ts 76.06% 28 Missing ⚠️
.../openapi-ts/src/plugins/@hey-api/schemas/plugin.ts 50.00% 3 Missing ⚠️
...enapi-ts/src/openApi/shared/utils/discriminator.ts 85.71% 2 Missing ⚠️
...kages/openapi-ts/src/openApi/3.0.x/parser/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1267      +/-   ##
==========================================
- Coverage   67.63%   67.56%   -0.08%     
==========================================
  Files         132      133       +1     
  Lines       19684    19841     +157     
  Branches     1775     1784       +9     
==========================================
+ Hits        13314    13405      +91     
- Misses       6366     6432      +66     
  Partials        4        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov