Skip to content

fix: set query key base url from supplied client if provided#1010

Merged
mrlubos merged 1 commit intomainfrom
fix/tanstack-query-key-client
Sep 4, 2024
Merged

fix: set query key base url from supplied client if provided#1010
mrlubos merged 1 commit intomainfrom
fix/tanstack-query-key-client

Conversation

@mrlubos
Copy link
Member

@mrlubos mrlubos commented Sep 4, 2024

Closes #987

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 5:48am

@changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2024

🦋 Changeset detected

Latest commit: b6e58c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@example/openapi-ts-tanstack-svelte-query Patch
@example/openapi-ts-tanstack-react-query Patch
@example/openapi-ts-tanstack-vue-query Patch
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mrlubos mrlubos marked this pull request as ready for review September 4, 2024 05:42
@codecov
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.19%. Comparing base (a254df1) to head (b6e58c6).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...napi-ts/src/plugins/@tanstack/query-core/plugin.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1010   +/-   ##
=======================================
  Coverage   76.19%   76.19%           
=======================================
  Files          89       89           
  Lines       10973    10973           
  Branches     1113     1113           
=======================================
  Hits         8361     8361           
  Misses       2605     2605           
  Partials        7        7           
Flag Coverage Δ
unittests 76.19% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 4, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@hey-api/client-axios@1010
pnpm add https://pkg.pr.new/@hey-api/client-fetch@1010
pnpm add https://pkg.pr.new/@hey-api/openapi-ts@1010

commit: b6e58c6

@mrlubos mrlubos merged commit 12df29b into main Sep 4, 2024
@mrlubos mrlubos deleted the fix/tanstack-query-key-client branch September 4, 2024 05:54
@github-actions github-actions bot mentioned this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

react-query createQueryKey uses baseUrl of global client rather than options.client

1 participant