Verify authenticity of signed payload #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekmach
approved these changes
Dec 20, 2018
wojtekmach
added a commit
to hexpm/hex
that referenced
this pull request
Dec 20, 2018
This was referenced Dec 30, 2018
wojtekmach
reviewed
Dec 30, 2018
| @@ -31,21 +31,21 @@ Get all package versions from repository: | |||
| ```erlang | |||
| > hex_repo:get_versions(Config). | |||
| {ok, {200, ..., | |||
| #{packages => [ | |||
There was a problem hiding this comment.
@ericmj to recap, previously we had:
> hex_repo:get_versions(Config)
{ok, {200, _, #{packages => Packages}}}
now we have:
> hex_repo:get_versions(Config)
{ok, {200, _, Packages}}
which means we'd no longer be able to associate any "metadata" with the versions resource in a backwards compatible way (adding new keys to the return map). I think that's OK, I can't think of anything we'd use it for, but just mentioning it. Thoughts?
There was a problem hiding this comment.
I think it's better this way, the other "metadata" wasn't really documented in the first place, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.