Replace exportAsync() #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SukkaW
approved these changes
May 15, 2020
Member
SukkaW
left a comment
SukkaW
left a comment
There was a problem hiding this comment.
Noticed that the test on Node.js 10 has failed.
Closed
SukkaW
requested changes
May 17, 2020
segayuu
force-pushed
the
Replace-exportAsync
branch
from
ac1e8d6 to
f9f2dbf
Compare
Member
|
cc @hexojs/core |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
exportAsync()currently depends on Stream.However, by using
FileHandle#writev(), you can implement streaming IO while eliminating the large abstract Stream.