Skip to content

Conversation

@D-Sketon
Copy link
Member

@D-Sketon D-Sketon commented Apr 27, 2024

Promise in document.ts is incorrectly labeled as native Promise

@coveralls
Copy link

coveralls commented Apr 27, 2024

Pull Request Test Coverage Report for Build 8879192041

Details

  • 78 of 79 (98.73%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 98.275%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/schema.ts 7 8 87.5%
Totals Coverage Status
Change from base Build 8733681669: 0.001%
Covered Lines: 4386
Relevant Lines: 4463

💛 - Coveralls

SukkaW
SukkaW previously approved these changes Apr 27, 2024
Co-authored-by: yoshinorin <yoshinorin.net@outlook.com>
Signed-off-by: D-Sketon <2055272094@qq.com>
Co-authored-by: yoshinorin <yoshinorin.net@outlook.com>
Signed-off-by: D-Sketon <2055272094@qq.com>
@D-Sketon
Copy link
Member Author

Test failed.

Not found in manifest. Falling back to download directly from Node
Error: Unable to find Node version '14' for platform darwin and architecture arm64.

@yoshinorin
Copy link
Member

Test failed.

IMHO, it's okay to merge because it's caused by CI env. Probably same issues occur in other repositories, so I think it's okay to start to drop Node.js 14 and 16.

@SukkaW SukkaW merged commit 2c89f53 into hexojs:master May 2, 2024
@D-Sketon D-Sketon deleted the fix/type branch May 2, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants