Change stream used inside "Warehouse#save()" to correspond to backpressure. #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change stream used inside "Warehouse#save()" to correspond to backpressure.
Contributor
|
That seems like a good idea @segayuu 👍🏼 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Warehouse#save(), due to its characteristics, it may cause memory exhaustion if it does not correspond to backpressure.
It is simple in the current implementation, but if backpressure is not supported, it is faster to use fs.writeFile().
Corresponding to backpressure means reducing memory to use as much as possible, not sending information more than necessary to Writable, interrupting processing as soon as possible when Writable asks for interruption is.
To deal with these we have added dependencies on the "json-stream-stringify" library.