-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: migrate to GitHub Actions #1647
Conversation
} else { | ||
themeNames.push(name); | ||
themes.add(name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set will be deduped automatically, no need to wrap it in else
. But it is fine.
@@ -6,51 +6,71 @@ const { join } = require('path'); | |||
|
|||
const { listDir } = require('hexo-fs'); | |||
const { log } = hexo; | |||
const sizeOf = require('image-size'); | |||
const sharp = require('sharp'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sharp requires node-gyp to build. Better enable node_modules cache in the CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caching node_modules
may cause the test to fail and is not recommended
sharp
is also used in scripts/responsive.js
, I believe this modification will not worsen the running time of the installation script
TODO: |
Theme name validation passed. |
Switch to GitHub actions. Automated testing is more efficient than the manual review we currently use.
See also #837 #1458