ci: migrate to GitHub Actions #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
SukkaW
reviewed
May 1, 2021
| } else { | ||
| themeNames.push(name); | ||
| themes.add(name); |
There was a problem hiding this comment.
Set will be deduped automatically, no need to wrap it in else. But it is fine.
SukkaW
requested changes
May 1, 2021
| @@ -6,51 +6,71 @@ const { join } = require('path'); | |||
|
|
|||
| const { listDir } = require('hexo-fs'); | |||
| const { log } = hexo; | |||
| const sizeOf = require('image-size'); | |||
| const sharp = require('sharp'); | |||
There was a problem hiding this comment.
Sharp requires node-gyp to build. Better enable node_modules cache in the CI
There was a problem hiding this comment.
Caching node_modules may cause the test to fail and is not recommended
sharp is also used in scripts/responsive.js, I believe this modification will not worsen the running time of the installation script
|
TODO: |
SukkaW
approved these changes
May 1, 2021
|
Theme name validation passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to GitHub actions. Automated testing is more efficient than the manual review we currently use.
See also #837 #1458