Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate to monorepo #5273

Closed
wants to merge 0 commits into from
Closed

migrate to monorepo #5273

wants to merge 0 commits into from

Conversation

uiolee
Copy link
Member

@uiolee uiolee commented Aug 20, 2023 •
edited
Loading

@uiolee uiolee linked an issue Aug 20, 2023 that may be closed by this pull request
The proposal of using monorepo #4353
Open
@uiolee uiolee mentioned this pull request Aug 21, 2023
Open
@yoshinorin
Copy link
Member

yoshinorin commented Sep 1, 2023 •
edited
Loading

Very IMHO I would like to release the v7.0.0 before migrating to a monorepo first. Because, it's not good to develop for v7.0.0 in parallel with the master branch for long terms. There are various issue, such as contributers not aware of the v7.0.0 branch and they submitting pull-request to the master branch. And we have to keep resolve many of conflicts between master and v7.0.0. etc...

@uiolee
Copy link
Member Author

uiolee commented Sep 2, 2023 •
edited
Loading

I agree. I would recommend going back to the main branch.

@uiolee uiolee marked this pull request as draft September 6, 2023 13:30
@stevenjoezhang stevenjoezhang changed the base branch from v7.0.0 to master October 25, 2023 05:02
@uiolee uiolee closed this Nov 7, 2023
@yoshinorin
Copy link
Member

Personally, I want to migrate hexo to mono in v8.0.0.

@hexojs hexojs deleted a comment from github-actions bot Nov 9, 2023
@hexojs hexojs deleted a comment from coveralls Nov 9, 2023
@uiolee
Copy link
Member Author

uiolee commented Nov 9, 2023

Do you mean after the release of v8? Or before?

I think it's acceptable to migrate at any time because it doesn't affect the code or the users.

@yoshinorin
Copy link
Member

yoshinorin commented Nov 10, 2023 •
edited
Loading

it doesn't affect the code or the users.

Oh, sorry I didn't know that. If we no need to rename package etc... we can publish it before v8.0.0.

@yoshinorin yoshinorin mentioned this pull request Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The proposal of using monorepo
2 participants
@uiolee @yoshinorin