Skip to content

refactor: ignore yarn caches & fix test virtual path#5205

Closed
dimaslanjaka wants to merge 5 commits intohexojs:masterfrom
dimaslanjaka:master
Closed

refactor: ignore yarn caches & fix test virtual path#5205
dimaslanjaka wants to merge 5 commits intohexojs:masterfrom
dimaslanjaka:master

Conversation

@dimaslanjaka
Copy link
Contributor

What does it do?

  • fixed test failure caused by 8b95bbc
  • ignore yarn caches for someones who using yarn to install

Pull request tasks

@github-actions
Copy link

How to test

git clone -b master https://github.com/dimaslanjaka/hexo.git
cd hexo
npm install
npm test

@dimaslanjaka
Copy link
Contributor Author

@SukkaW review pls

@stevenjoezhang
Copy link
Member

In what situations would "node_modules" appear in a subdirectory?

- add cygwin support (tested on windows 10 latest cygwin version)
- add WSL support (tested on windows 10 WSL ubuntu)
- add windows cmd support (tested commit on windows 10 cmd)
update git hook `pre-commit` for multiple platforms
- add cygwin support (tested on windows 10 latest cygwin version)
- add WSL support (tested on windows 10 WSL ubuntu)
- add windows cmd support (tested commit on windows 10 cmd)
@uiolee
Copy link
Member

uiolee commented Oct 13, 2023

I think this PR is outdated. PR #5153 has been reverted

@uiolee uiolee closed this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants