Conversation
How to testgit clone -b refactor-types https://github.com/Pcrab/hexo.git
cd hexo
npm install
npm test |
SukkaW
reviewed
Apr 1, 2023
SukkaW
reviewed
Apr 1, 2023
lib/plugins/console/index.ts
Outdated
| @@ -1,4 +1,6 @@ | |||
| export = function(ctx) { | |||
| import Hexo from '../../hexo'; | |||
Member
There was a problem hiding this comment.
Suggested change
| import Hexo from '../../hexo'; | |
| import type Hexo from '../../hexo'; |
Use import type for type only imports.
Contributor
Author
There was a problem hiding this comment.
Fixed in 3ad806d.
Maybe we should add a rule in .eslintrc.json to enforce this style?
{
"rules": {
"@typescript-eslint/consistent-type-imports": "warn",
}
}
stevenjoezhang
approved these changes
Apr 5, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Add types to Hexo class and extend apis.
Only types are changed except for
lib/extend/tag.ts, where I added an intermediate variable. All these changes should have no effect on runtime behavior.This may help plugin authors who can now add hexo as devdependency and add
declare var hexo: import("hexo")toglobal.d.tsto get better type inference.Screenshots
After adds
I can get better type inference like this:
which used to be just any type.
Pull request tasks