Skip to content

fix(post-asset): strip /\.html?$/ extensions on permalink#2881

Merged
NoahDragon merged 1 commit intomasterfrom
fix-2134
Dec 4, 2017
Merged

fix(post-asset): strip /\.html?$/ extensions on permalink#2881
NoahDragon merged 1 commit intomasterfrom
fix-2134

Conversation

@JLHwung
Copy link
Collaborator

@JLHwung JLHwung commented Dec 4, 2017

Fixes #2134
Closes #2551
Closes #2504

cc @Alex1990 @changyuheng

Thank you for creating a pull request to contribute to Hexo code! Before you open the request please review the following guidelines and tips to help it be more easily integrated:

  • Add test cases for the changes.
  • Passed the CI test.

@JLHwung JLHwung requested review from NoahDragon and leesei December 4, 2017 06:02
@coveralls
Copy link

coveralls commented Dec 4, 2017

Coverage Status

Coverage increased (+0.0007%) to 97.226% when pulling 971c56e on fix-2134 into 08a9b5f on master.

@coveralls
Copy link

coveralls commented Dec 4, 2017

Coverage Status

Coverage increased (+0.0007%) to 97.226% when pulling 597bf1b on fix-2134 into 08a9b5f on master.

@coveralls
Copy link

coveralls commented Dec 4, 2017

Coverage Status

Coverage increased (+0.0007%) to 97.226% when pulling 91d6110 on fix-2134 into 08a9b5f on master.

@hexojs hexojs deleted a comment from coveralls Dec 4, 2017
Copy link
Member

@NoahDragon NoahDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for looking into this bug. I already forgot I have committed to fix it...

@NoahDragon NoahDragon merged commit 284c1b9 into master Dec 4, 2017
@NoahDragon NoahDragon deleted the fix-2134 branch December 4, 2017 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants