Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove babel and mjs #94

Merged
merged 5 commits into from
Aug 14, 2019
Merged

Remove babel and mjs #94

merged 5 commits into from
Aug 14, 2019
+93 −112

Conversation

segayuu
Copy link
Contributor

@segayuu segayuu commented Jul 23, 2019

No description provided.

@segayuu segayuu requested a review from a team July 23, 2019 10:42
@segayuu
Copy link
Contributor Author

segayuu commented Jul 23, 2019

The travis CI error could not be confirmed locally.
It is possible that the test itself is broken in CI.

@JLHwung
Copy link
Contributor

JLHwung commented Jul 23, 2019

I can reproduce test failure on my machine. The test fixture is highly related to the output of hexo helpers and highlight.js.

Since hello-world does not contain any TeX definition, I suggest we rewrite the test and treat it as a hexo smoke test. For example we can test if it generates non-empty fixture.

As long as tag-escape and other TeX related test pass, it should be good to go.

Could you enable the skipped block and inline test?

@curbengh curbengh mentioned this pull request Jul 29, 2019
Closed
@yoshinorin yoshinorin mentioned this pull request Aug 3, 2019
Merged
@segayuu
Copy link
Contributor Author

segayuu commented Aug 13, 2019 •
edited
Loading

I don't know how to adapt the review.
If you get an error on this side, you can investigate, but it works in my environment.

  • OS: win10
  • Node: 12.8.0
  • NPM: 6.10.3
  • Git: 2.22.0.windows.1

@yoshinorin
Copy link
Member

yoshinorin commented Aug 13, 2019 •
edited
Loading

@segayuu
This test failure seems does not occur on native Windows.
But I can reproduce it using by WSL.

  • Windows 10
  • WSL (Ubuntu 18.04.1)
  • Node.js v12.3.1
  • npm 6.10.2
  • git 2.17

Please be careful, npm script might be a failure on native Windows if execute npm install once on WSL.

Please delete node_modules and re-execute npm install on native Windows if you face a npm script failure on native Windows after execute npm install on WSL.

@curbengh
Copy link
Contributor

curbengh commented Aug 14, 2019 •
edited
Loading

This test failure seems does not occur on native Windows.

Line ending difference?

@yoshinorin
Copy link
Member

Maybe I got it. The test failure caused by hexo-renderer-marked version.

The test success on Linux (WSL) if npm-script preset:clone change to following.

"pretest:clone": "git clone --recursive https://github.com/hexojs/hexo-starter.git ./test/site && cd ./test/site && git checkout a4d53738d734b1151576337ea427b6186115943a"

The commit hash a4d53738d734b1151576337ea427b6186115943a is parent commit of update hexo-renderer-marked to v1.0.1

Line ending difference?

Maybe no. But, I don't know why the test passes on native Windows. That's weird 🤔

@segayuu
Copy link
Contributor Author

segayuu commented Aug 14, 2019

Thank @yoshinorin !

@tomap tomap merged commit cba483f into master Aug 14, 2019
@segayuu segayuu deleted the Remove-babel-and-mjs branch August 15, 2019 00:37
@curbengh
Copy link
Contributor

Maybe I got it. The test failure caused by hexo-renderer-marked version.

similar issue with hexojs/hexo#3571?

@curbengh curbengh mentioned this pull request Aug 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomap tomap tomap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@segayuu @JLHwung @yoshinorin @curbengh @tomap