-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore posts which were set as draft in the front-matter #44
Conversation
atom.xml
Outdated
@@ -22,7 +22,7 @@ | |||
<published>{{ post.date.toISOString() }}</published> | |||
<updated>{{ post.updated.toISOString() }}</updated> | |||
{% if config.feed.content and post.content %} | |||
<content type="html"><![CDATA[{{ post.content | safe }}]]></content> | |||
<content type="html"><![CDATA[{{ post.content | uriencode }}]]></content> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why need to change this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sucks when the post's content contains emoji chars like 😀
Use the uriencode
filter can resolve this problem.
o2team/o2team.github.io#21
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification.
LGTM. Could you please fix the jscs error? |
package.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "hexo-generator-feed", | |||
"version": "1.2.0", | |||
"name": "hexo-generator-xfeed", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice the package name has changed. Is it a typo?
package.json
Outdated
"hexo": "^3.0.0", | ||
"jscs": "^2.11.0", | ||
"cheerio": "^0.22.0", | ||
"eslint": "^3.19.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest keeping these package in their old version. I assume the CI errors are caused by the new versions.
…int-config-hexo has a dependence on babel-eslint, but our project miss it.
1 similar comment
Thanks for your contribution. |
No description provided.