ignore posts which were set as draft in the front-matter #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahDragon
reviewed
Apr 18, 2017
atom.xml
Outdated
| @@ -22,7 +22,7 @@ | |||
| <published>{{ post.date.toISOString() }}</published> | |||
| <updated>{{ post.updated.toISOString() }}</updated> | |||
| {% if config.feed.content and post.content %} | |||
| <content type="html"><![CDATA[{{ post.content | safe }}]]></content> | |||
| <content type="html"><![CDATA[{{ post.content | uriencode }}]]></content> | |||
There was a problem hiding this comment.
It sucks when the post's content contains emoji chars like 😀
Use the uriencode filter can resolve this problem.
o2team/o2team.github.io#21
There was a problem hiding this comment.
Thanks for the clarification.
|
LGTM. Could you please fix the jscs error? |
NoahDragon
reviewed
Apr 20, 2017
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "hexo-generator-feed", | |||
| "version": "1.2.0", | |||
| "name": "hexo-generator-xfeed", | |||
There was a problem hiding this comment.
I notice the package name has changed. Is it a typo?
NoahDragon
reviewed
Apr 20, 2017
package.json
Outdated
| "hexo": "^3.0.0", | ||
| "jscs": "^2.11.0", | ||
| "cheerio": "^0.22.0", | ||
| "eslint": "^3.19.0", |
There was a problem hiding this comment.
I suggest keeping these package in their old version. I assume the CI errors are caused by the new versions.
…int-config-hexo has a dependence on babel-eslint, but our project miss it.
1 similar comment
|
Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.