fix: compatibility with null post.updated #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
curbengh
commented
Nov 28, 2019
test/index.js
Outdated
| @@ -340,6 +341,25 @@ describe('Feed generator', () => { | |||
| feed_url: hexo.config.root + feedCfg.path | |||
| })); | |||
| }); | |||
|
|
|||
| it('no updated date', () => { | |||
| hexo.config.optional_updated = true; | |||
There was a problem hiding this comment.
Most probably this config won't be applied as processor doesn't run here.
curbengh
commented
Nov 28, 2019
test/index.js
Outdated
| @@ -45,7 +45,8 @@ describe('Feed generator', () => { | |||
| return Post.insert([ | |||
| {source: 'foo', slug: 'foo', content: '<h6>TestHTML</h6>', date: 1e8}, | |||
| {source: 'bar', slug: 'bar', date: 1e8 + 1}, | |||
| {source: 'baz', slug: 'baz', title: 'With Image', image: 'test.png', date: 1e8 - 1} | |||
| {source: 'baz', slug: 'baz', title: 'With Image', image: 'test.png', date: 1e8 - 1}, | |||
| {source: 'date', slug: 'date', title: 'date', date: 1e8 - 2, updated: undefined} | |||
There was a problem hiding this comment.
will add a test case with valid updated.
curbengh
changed the title
curbengh
force-pushed
the
optional-updated
branch
2 times, most recently
from
404581a
to
8fe15cd
Compare
curbengh
commented
Jun 25, 2020
stevenjoezhang
approved these changes
Jul 26, 2020
SukkaW
approved these changes
Jul 26, 2020
curbengh
force-pushed
the
optional-updated
branch
from
8fe15cd
to
e597747
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compatibility with hexojs/hexo#3887 hexojs/hexo#4278