-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle sites with no posts #107
Conversation
coverage decreased probably means I should add some tests... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The coverage ratio drops because of the increased LOC. Maybe you can add a test case about no post is given to cover that.
I've added the relevant unit test. |
hexo-generator-sitemap may need this as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in local machine.
see tomap/hexo-theme-minidyne-demo@2ddea21
The fix is a bit dumb, but I don't feel we need to generate an empty atom or rss file in that case.
Related to issue #43 (last comments)