Updated Atom.xml to use correct namespace #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per https://tools.ietf.org/html/rfc4287#section-1.2, the correct xml namespace is "http://www.w3.org/2005/Atom", which some feed validators will validate against, even though the "https" version of that URL is also valid. fixes hexojs#104
|
I rolled back my npm version of the feed generator to 1.2.2, and was able to confirm with the "http" version of the xml namespace, the feed validates correctly enough to say "valid" rather than failed:
|
Merged
|
I just found out using http in namespace is especially important in svg. browser would not display svg if the namespace is in https. |
curbengh
pushed a commit
to curbengh/curbengh.github.io
that referenced
this pull request
Apr 15, 2020
curbengh
pushed a commit
to curbengh/curbengh.github.io
that referenced
this pull request
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://tools.ietf.org/html/rfc4287#section-1.2, the correct xml namespace is "http://www.w3.org/2005/Atom". When https is used, some feed validators will fail validation, even though the "https" version of that URL is also valid.
fixes #104