Skip to content

Add inheritance and interfaces lesson #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ssssank merged 5 commits into from
Mar 29, 2023
Merged

Add inheritance and interfaces lesson #128

ssssank merged 5 commits into from
Mar 29, 2023

Conversation

@Peopl3s
Copy link
Contributor

@Peopl3s Peopl3s commented Mar 7, 2023

No description provided.

forPelevin
forPelevin reviewed Mar 17, 2023
View reviewed changes
forPelevin
forPelevin reviewed Mar 17, 2023
View reviewed changes
@ssssank
Copy link
Contributor

ssssank commented Mar 27, 2023

@forPelevin @Peopl3s подскажите, вы закончили тут или что-то осталось подправить? :)

@Peopl3s
Copy link
Contributor Author

Peopl3s commented Mar 28, 2023

Вторым коммитом я внёс правки, но лишний взгляд со стороны лишним не будет)

@forPelevin
Copy link
Contributor

forPelevin commented Mar 28, 2023

меня все еще смущает название интерфейсов IAble, потому что это совсем не go way :) в остальном вопросов нет

Peopl3s added 3 commits March 29, 2023 06:49
@Peopl3s
Fixed a description of the example output
a96d170 
Added a description of the output according to the Hexlet style-guide
@Peopl3s
Added about the features of naming interfaces
9900b55 
Added about the features of naming interfaces in Golang https://go.dev/doc/effective_go#interface-names
@Peopl3s
Added h2 headers
c664565 
Added h2 headers for blocks about composition, embedding and interfaces
@Peopl3s
Copy link
Contributor Author

Peopl3s commented Mar 29, 2023

меня все еще смущает название интерфейсов IAble, потому что это совсем не go way :) в остальном вопросов нет

@forPelevin Дополнил согласно вашему комментарию

@forPelevin
Copy link
Contributor

forPelevin commented Mar 29, 2023

Отлично) LGTM

@ssssank ssssank merged commit de3eaf3 into hexlet-basics:main Mar 29, 2023
@Peopl3s
Copy link
Contributor Author

Peopl3s commented Mar 31, 2023

@ssssank а не подскажите через какое время время урок добавится на сайт?

@ssssank
Copy link
Contributor

ssssank commented Mar 31, 2023

Уже появился :)
https://code-basics.com/ru/languages/go/lessons/inheritance-interfaces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NatalieKonstantinova NatalieKonstantinova Awaiting requested review from NatalieKonstantinova

2 more reviewers

@ssssank ssssank ssssank left review comments

@forPelevin forPelevin forPelevin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Peopl3s @ssssank @forPelevin