Skip to content

Commit

Permalink
[GCM] Close the socket on connection factory shutdown
Browse files Browse the repository at this point in the history
We don't want to attempt to reuse a socket across shutdowns, and given
socket pools any open socket can be reused. Make sure to close the socket on
shutdown

BUG=392546

Review URL: https://codereview.chromium.org/381273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282551 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
zea@chromium.org committed Jul 11, 2014
1 parent 4939383 commit b52c239
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions google_apis/gcm/engine/connection_factory_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ ConnectionFactoryImpl::ConnectionFactoryImpl(
}

ConnectionFactoryImpl::~ConnectionFactoryImpl() {
CloseSocket();
net::NetworkChangeNotifier::RemoveNetworkChangeObserver(this);
if (pac_request_) {
network_session_->proxy_service()->CancelPacRequest(pac_request_);
Expand Down

0 comments on commit b52c239

Please sign in to comment.