*: use kubecsr mount, add readiness probe to etcd pod #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexfusion
reviewed
Sep 26, 2019
templates/master/00-master/_base/files/etc-kubernetes-manifests-etcd-member.yaml
Show resolved
Hide resolved
hexfusion
reviewed
Sep 26, 2019
| - name: kubeconfig | ||
| mountPath: /etc/kubernetes/kubeconfig | ||
| - name: sa | ||
| mountPath: /var/run/secrets/kubernetes.io/serviceaccount/ | ||
| containers: | ||
| - name: etcd-member | ||
| image: "{{.Images.etcdKey}}" |
There was a problem hiding this comment.
don't we need etcd-metrics as well?
There was a problem hiding this comment.
it is not critical for the workflow, once we learn from playing with etcd-member, we can patch the etcd-metrics with readiness probe upstream
There was a problem hiding this comment.
My understanding is that endpoints controller will see that port 2380 registered on etcd-member is not ready because it has not passed readiness probe and it will not add this pod ip to the ready ip addresses list, irrespective of the state of the etcd-metrics.
hexfusion
reviewed
Sep 26, 2019
templates/master/00-master/_base/files/etc-kubernetes-manifests-etcd-member.yaml
Show resolved
Hide resolved
hexfusion
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the etcd pod manifests to use
kube-client-agent mountsubcommand. It also adds readiness probe to etcd static pod. This should help make endpoints more reflective of state of pods consumed by CEO.Depends on coreos/kubecsr#30