main: reduce Error functions

hex7c0 · Dec 21, 2016 · 4fddb04 · 4fddb04
1 parent 7b29688
commit 4fddb04
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 35 deletions.
diff --git a/index.js b/index.js
@@ -24,30 +24,6 @@ var end = new RegExp(/(.+)/g);
 /*
  * functions
  */
-/**
- * empty function
- * 
- * @function end_empty
- */
-function end_empty() {
-
-  return;
-}
-
-/**
- * end with error. Propagate Error to callback
- * 
- * @function end_err
- * @param {next} next - continue routes
- * @param {String} code - response error
- * @return {Error}
- */
-function end_err(next, code) {
-
-  var err = new Error(code);
-  return next ? next(err) : err;
-}
-
 /**
  * end of work
  * 
@@ -227,9 +203,24 @@ function authentication(opt) {
   }
 
   // error handler
-  var err = end_err;
+  /**
+   * end with error. Propagate Error to callback
+   * 
+   * @function end_err
+   * @param {next} next - continue routes
+   * @param {String} code - response error
+   * @return {Error}
+   */
+  var err = function(next, code) {
+
+    var err = new Error(code);
+    return next ? next(err) : err;
+  };
   if (my.suppress) {
-    err = end_empty;
+    err = function() {
+
+      return;
+    };
   }
 
   /**

diff --git a/index.min.js b/index.min.js
@@ -1,12 +1,5 @@
 "use strict";
 
-function end_empty() {}
-
-function end_err(next, code) {
-    var err = new Error(code);
-    return next ? next(err) : err;
-}
-
 function end_work(err, next, code, res) {
     if (void 0 === code) return !next || next();
     var codes = http[code];
@@ -82,8 +75,11 @@ function authentication(opt) {
         var user = String(options.user || "admin"), password = String(options.password || "password");
         my.hash = new Buffer(user + ":" + password).toString("base64"), check = end_check;
     }
-    var err = end_err;
-    return my.suppress && (err = end_empty), options.ending === !1 ? basic_medium : basic_big;
+    var err = function(next, code) {
+        var err = new Error(code);
+        return next ? next(err) : err;
+    };
+    return my.suppress && (err = function() {}), options.ending === !1 ? basic_medium : basic_big;
 }
 
 var http = require("http").STATUS_CODES, crypto = require("crypto").createHash, setHeader = require("setheaders").setWritableHeader, reg = new RegExp(/^Basic (.*)$/), basic = new RegExp(/^([^:]*):(.*)$/), end = new RegExp(/(.+)/g);