Skip to content

reverse migration downQueries #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dylanscott merged 1 commit into from
Nov 20, 2025
Merged

reverse migration downQueries #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/commands/MigrationGenerateCommand.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export class MigrationGenerateCommand implements yargs.CommandModule {
const fileContent = await templater({
name: migrationName,
upQueries: sqlInMemory.upQueries,
downQueries: sqlInMemory.downQueries,
downQueries: sqlInMemory.downQueries.reverse(),
Copy link

@jkillian jkillian Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay to do this in place? Or do we need toReversed()?

Copy link
Contributor Author

@dylanscott dylanscott Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok since the original code did a reverse(), and unfortunately the TS build for the project is not using a recent enough lib setting to use toReversed() :(

});
const path = process.cwd() + "/" + (directory ? (directory + "/") : "") + filename;
await CommandUtils.createFile(path, fileContent);
Expand Down
Loading