Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate color / background #60

Closed
heuer opened this issue Jan 6, 2020 · 2 comments
Closed

Deprecate color / background #60

heuer opened this issue Jan 6, 2020 · 2 comments
Milestone
0.4.0

Comments

@heuer
Copy link
Owner

heuer commented Jan 6, 2020

Deprecate color and background, dark and light should be used to provide the color of the dark / light modules
@heuer heuer modified the milestones: 0.4.0, future Jan 6, 2020
@heuer heuer added the minor label Jan 8, 2020
@heuer
Copy link
Owner Author

heuer commented Jan 8, 2020 •
edited
Loading

Changed milestone to "future" since it's cheap to keep the keywords which were available since Segno 0.1.1 (2016-08-14)

The docs refer to the light / dark keywords so new users of Segno won't use the former keywords, while keeping the early adopters of Segno happy.

@heuer heuer mentioned this issue Jan 13, 2020
Closed
8 tasks
@heuer heuer modified the milestones: future, 0.4.0 Jan 13, 2020
@heuer
Copy link
Owner Author

heuer commented Jan 13, 2020

Solution: Deprecate in 0.4.0, throw away in 1.0.0, see #66

@heuer heuer removed the minor label Jan 13, 2020
heuer added a commit that referenced this issue Jan 20, 2020
@heuer
Deprecated color / background. Closes #60
44491cc
@heuer heuer closed this as completed Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
1 participant
@heuer