Skip to content

Conversation

@jooola
Copy link
Member

@jooola jooola commented Aug 15, 2025

  • Reduce the amount of duplicate tests for the actions calls,
  • Ensure consistency across all resources,
  • Have few good tests, instead of many with few coverage.

@codecov
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.55%. Comparing base (8de4107) to head (41c4fbc).
⚠️ Report is 46 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #545      +/-   ##
==========================================
+ Coverage   96.14%   96.55%   +0.40%     
==========================================
  Files          64       64              
  Lines        2928     2928              
==========================================
+ Hits         2815     2827      +12     
+ Misses        113      101      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jooola jooola force-pushed the generate-actions-tests branch from 27275d9 to 9b8c612 Compare August 15, 2025 19:43
@jooola
Copy link
Member Author

jooola commented Aug 18, 2025

Coverage has increased, because we now generate tests for the bound models get_actions* methods.

@jooola
Copy link
Member Author

jooola commented Aug 18, 2025

The trick for this is the parametrized fixture:

@pytest.fixture(params=resources_with_actions.keys())

https://docs.pytest.org/en/stable/how-to/fixtures.html#fixture-parametrize

Copy link
Member

@apricote apricote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeet that duplicate code!

@jooola jooola changed the title test: generate actions clients tests for each resource client test: generate actions tests for each resource that support actions Aug 18, 2025
@jooola jooola changed the title test: generate actions tests for each resource that support actions test: generate actions tests for each resource that have actions Aug 18, 2025
@jooola jooola merged commit f933cc3 into main Aug 18, 2025
11 of 12 checks passed
@jooola jooola deleted the generate-actions-tests branch August 18, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants